Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add i18n #10

Conversation

alejandropaciotti
Copy link

@alejandropaciotti alejandropaciotti commented Oct 31, 2018

This PR implement the react-native-languages library.

Following this example.

Files changed:

  • App/Containers/Example/ExampleScreen.js

Files added:

  • App/App.js
  • App/Locales/traslations/en.json
  • App/Locales/traslations/es.json
  • App/Locales/i18n.js

@AurelGit
Copy link
Collaborator

Thanks @alejandropaciotti ! Really useful feature.

It seems that react-native-i18n is now deprecated, do you think it's possible to use react-native-languages ?
Did you choose react-native-i18n for a particular reason ?

In any case, love your contribution :)

@alejandropaciotti
Copy link
Author

Thanks @alejandropaciotti ! Really useful feature.

It seems that react-native-i18n is now deprecated, do you think it's possible to use react-native-languages ?
Did you choose react-native-i18n for a particular reason ?

In any case, love your contribution :)

I found that react-native-i18n is deprecated once I finalized the PR.
I'll change for the react-native-languages library.

@alejandropaciotti
Copy link
Author

Thanks @alejandropaciotti ! Really useful feature.
It seems that react-native-i18n is now deprecated, do you think it's possible to use react-native-languages ?
Did you choose react-native-i18n for a particular reason ?
In any case, love your contribution :)

I found that react-native-i18n is deprecated once I finalized the PR.
I'll change for the react-native-languages library.

Done !!

@JeremyDolle
Copy link
Collaborator

Hi @alejandropaciotti , it doesn't seem to work on android probably because of gradle's version. Did you have an error like this on android ?

* What went wrong:
A problem occurred evaluating project ':react-native-languages'.
> Could not find method implementation() for arguments [com.facebook.react:react-native:+] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

@alejandropaciotti
Copy link
Author

Hi @alejandropaciotti , it doesn't seem to work on android probably because of gradle's version. Did you have an error like this on android ?

* What went wrong:
A problem occurred evaluating project ':react-native-languages'.
> Could not find method implementation() for arguments [com.facebook.react:react-native:+] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

Sorry Jeremy, I haven't tried in Android yet. But I will

@AurelGit
Copy link
Collaborator

I’m closing this issue because it has been inactive for a few months. This probably means that it is not reproducible or it has been fixed in a newer version. If it’s an enhancement and hasn’t been taken on for so long, then it seems no one has the time to implement this.

Please reopen if you still encounter this issue or need to implement this feature.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants