Merge pull request #84 from moufmouf/fsockopen

Adding fsockopen to list of supported functions

generated/functionsList.php

@@ -548,6 +548,7 @@
     'mysqlnd_qc_set_storage_handler',
     'closelog',
     'dns_get_record',
+    'fsockopen',
     'getprotobyname',
     'getprotobynumber',
     'header_register_callback',

generated/network.php

@@ -253,6 +253,65 @@ function dns_get_record(string $hostname, int $type = DNS_ANY, array &$authns =
 }
 
 
+/**
+ * Initiates a socket connection to the resource specified by
+ * hostname.
+ *
+ * PHP supports targets in the Internet and Unix domains as described in
+ * .  A list of supported transports can also be
+ * retrieved using stream_get_transports.
+ *
+ * The socket will by default be opened in blocking mode.  You can
+ * switch it to non-blocking mode by using
+ * stream_set_blocking.
+ *
+ * The function stream_socket_client is similar but
+ * provides a richer set of options, including non-blocking connection and the
+ * ability to provide a stream context.
+ *
+ * @param string $hostname If OpenSSL support is
+ * installed, you may prefix the hostname
+ * with either ssl:// or tls:// to
+ * use an SSL or TLS client connection over TCP/IP to connect to the
+ * remote host.
+ * @param int $port The port number. This can be omitted and skipped with
+ * -1 for transports that do not use ports, such as
+ * unix://.
+ * @param int $errno If provided, holds the system level error number that occurred in the
+ * system-level connect() call.
+ *
+ * If the value returned in errno is
+ * 0 and the function returned FALSE, it is an
+ * indication that the error occurred before the
+ * connect() call. This is most likely due to a
+ * problem initializing the socket.
+ * @param string $errstr The error message as a string.
+ * @param float $timeout The connection timeout, in seconds.
+ *
+ * If you need to set a timeout for reading/writing data over the
+ * socket, use stream_set_timeout, as the
+ * timeout parameter to
+ * fsockopen only applies while connecting the
+ * socket.
+ * @return resource fsockopen returns a file pointer which may be used
+ * together with the other file functions (such as
+ * fgets, fgetss,
+ * fwrite, fclose, and
+ * feof). If the call fails, it will return FALSE
+ * @throws NetworkException
+ *
+ */
+function fsockopen(string $hostname, int $port = -1, int &$errno = null, string &$errstr = null, float $timeout = null)
+{
+    error_clear_last();
+    $result = \fsockopen($hostname, $port, $errno, $errstr, $timeout);
+    if ($result === false) {
+        throw NetworkException::createFromPhpError();
+    }
+    return $result;
+}
+
+
 /**
  * getprotobyname returns the protocol number
  * associated with the protocol name as per

generator/src/DocPage.php

@@ -32,15 +32,15 @@ public function detectFalsyFunction(): bool
 
         if (preg_match('/&warn\.deprecated\.function-(\d+-\d+-\d+)\.removed-(\d+-\d+-\d+)/', $file, $matches)) {
             $removedVersion = $matches[2];
-            [$major, $minor, $fix] = explode('-', $removedVersion);
+            [$major, $minor] = explode('-', $removedVersion);
             if ($major < 7 || ($major == 7 && $minor == 0)) {
                 // Ignore function if it was removed before PHP 7.1
                 return false;
             }
         }
         if (preg_match('/&warn\.removed\.function-(\d+-\d+-\d+)/', $file, $matches) && isset($matches[2])) {
             $removedVersion = $matches[2];
-            [$major, $minor, $fix] = explode('-', $removedVersion);
+            [$major, $minor] = explode('-', $removedVersion);
             if ($major < 7 || ($major == 7 && $minor == 0)) {
                 // Ignore function if it was removed before PHP 7.1
                 return false;
@@ -77,6 +77,9 @@ public function detectFalsyFunction(): bool
         if (preg_match('/&false;\s+if\s+the\s+number\s+of\s+elements\s+for\s+each\s+array\s+isn\'t\s+equal/m', $file)) {
             return true;
         }
+        if (preg_match('/If\s+the\s+call\s+fails,\s+it\s+will\s+return\s+&false;/m', $file)) {
+            return true;
+        }
 
         return false;
     }

generator/src/FileCreator.php

@@ -7,14 +7,9 @@
 use function file_exists;
 use PhpOffice\PhpSpreadsheet\Spreadsheet;
 use PhpOffice\PhpSpreadsheet\Writer\Xlsx;
-use function ucfirst;
 
 class FileCreator
 {
-    public function __construct()
-    {
-    }
-
     /**
      * This function generate an xls file
      *
@@ -25,7 +20,6 @@ public function generateXlsFile(array $protoFunctions, string $path): void
     {
         $spreadsheet = new Spreadsheet();
         $numb = 1;
-        $status = '';
 
         $sheet = $spreadsheet->getActiveSheet();
         $sheet->setCellValue('A1', 'Function name');

generator/src/Method.php

@@ -75,7 +75,7 @@ public function getParams(): array
 
                 if (preg_match('/This parameter has been removed in PHP (\d+\.\d+\.\d+)/', $notes, $matches)) {
                     $removedVersion = $matches[1];
-                    [$major, $minor, $fix] = explode('.', $removedVersion);
+                    [$major, $minor] = explode('.', $removedVersion);
                     if ($major < 7 || ($major == 7 && $minor == 0)) {
                         // Ignore parameter if it was removed before PHP 7.1
                         continue;

generator/src/Parameter.php

@@ -2,7 +2,6 @@
 namespace Safe;
 
 use Safe\PhpStanFunctions\PhpStanFunction;
-use Safe\PhpStanFunctions\PhpStanFunctionMapReader;
 
 class Parameter
 {

generator/src/PhpStanFunctions/PhpStanFunctionMapReader.php

@@ -3,8 +3,6 @@
 
 namespace Safe\PhpStanFunctions;
 
-use Safe\PhpStanFunctions\PhpStanFunction;
-
 class PhpStanFunctionMapReader
 {
     /**

generator/src/ScanObjectsCommand.php

@@ -6,7 +6,6 @@
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
-use Symfony\Component\Process\Process;
 
 class ScanObjectsCommand extends Command
 {

generator/src/WritePhpFunction.php

@@ -2,12 +2,6 @@
 
 namespace Safe;
 
-use function in_array;
-use function is_numeric;
-use function strtolower;
-use function strtoupper;
-use function var_export;
-
 class WritePhpFunction
 {
     /**
@@ -27,9 +21,8 @@ public function getPhpPrototypeFunction(): string
     {
         if ($this->method->getFunctionName()) {
             return 'function '.$this->method->getFunctionName().'('.$this->displayParamsWithType($this->method->getParams()).')'.': '.$this->method->getReturnType().'{}';
-        } else {
-            return '';
         }
+        return '';
     }
 
     /*

generator/tests/DocPageTest.php

@@ -14,6 +14,7 @@ public function testDetectFalsyFunction() {
         $filesize = new DocPage(__DIR__ . '/../doc/doc-en/en/reference/filesystem/functions/filesize.xml');
         $sessionRegister = new DocPage(__DIR__ . '/../doc/doc-en/en/reference/session/functions/session-register.xml');
         $mcryptDecrypt = new DocPage(__DIR__ . '/../doc/doc-en/en/reference/mcrypt/functions/mcrypt-decrypt.xml');
+        $fsockopen = new DocPage(__DIR__ . '/../doc/doc-en/en/reference/network/functions/fsockopen.xml');
 
         $this->assertTrue($pregMatch->detectFalsyFunction());
         $this->assertFalse($implode->detectFalsyFunction());
@@ -22,5 +23,6 @@ public function testDetectFalsyFunction() {
         $this->assertTrue($filesize->detectFalsyFunction());
         $this->assertFalse($sessionRegister->detectFalsyFunction());
         $this->assertTrue($mcryptDecrypt->detectFalsyFunction());
+        $this->assertTrue($fsockopen->detectFalsyFunction());
     }
 }

lib/special_cases.php

@@ -139,23 +139,22 @@ function apcu_fetch($key)
  * -1 (no limit).
  * @param int $count If specified, this variable will be filled with the number of
  * replacements done.
- * @return string|array|null preg_replace returns an array if the
+ * @return string|array preg_replace returns an array if the
  * subject parameter is an array, or a string
  * otherwise.
  *
  * If matches are found, the new subject will
  * be returned, otherwise subject will be
  * returned unchanged.
  *
- * Returns a file pointer resource on success, .
  * @throws PcreException
  *
  */
 function preg_replace($pattern, $replacement, $subject, int $limit = -1, int &$count = null)
 {
     error_clear_last();
     $result = \preg_replace($pattern, $replacement, $subject, $limit, $count);
-    if (preg_last_error() !== PREG_NO_ERROR) {
+    if (preg_last_error() !== PREG_NO_ERROR || $result === null) {
         throw PcreException::createFromPhpError();
     }
     return $result;

rector-migrate.yml

@@ -549,6 +549,7 @@ services:
       mysqlnd_qc_set_storage_handler: 'Safe\mysqlnd_qc_set_storage_handler'
       closelog: 'Safe\closelog'
       dns_get_record: 'Safe\dns_get_record'
+      fsockopen: 'Safe\fsockopen'
       getprotobyname: 'Safe\getprotobyname'
       getprotobynumber: 'Safe\getprotobynumber'
       header_register_callback: 'Safe\header_register_callback'