Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo #24

Merged
merged 1 commit into from
Sep 14, 2018
Merged

Typo #24

merged 1 commit into from
Sep 14, 2018

Conversation

simoheinonen
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 55

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 26.351%

Totals Coverage Status
Change from base Build 54: 0.0%
Covered Lines: 117
Relevant Lines: 444

💛 - Coveralls

@peter279k
Copy link

After checking Travis CI build log, it seems that's broken.

And the message is here: The process "vendor/bin/phpcbf" exceeded the timeout of 60 seconds.
The work cd generator && ./safe.php generate && cd .. execution time is so long that the Travis CI kill that.

I think it should set the travis_wait before this command to complete this work successfully 👍 .

@moufmouf
Copy link
Member

Ok, timeout if fixed in #28 .
I'm merging this.

Thanks @simoheinonen and thanks @peter279k for the analysis.

@moufmouf moufmouf merged commit 315cdf7 into thecodingmachine:master Sep 14, 2018
@peter279k
Copy link

peter279k commented Sep 14, 2018

Well, the issue is still existed.
The timeout setting should set in .travis.yml, not in source code.
Please check the Travis CI builld log.

@moufmouf
Copy link
Member

Ho, these are 2 separate issues.

In the previous log, the issue was about the CS fixer taking too much time (it's a process I call from the PHP, and I did put a longer timeout in the PHP code). It was PHP that was timing out, not travis.

But right now, there is another issue. This time, it is indeed Travis that is timing out. This is because the SVN for the PHP documentation has been down for about one hour. There is nothing I can do here but to wait that the SVN is put up again... :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants