Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty strings functions #303

Merged
merged 2 commits into from
Oct 17, 2021
Merged

Empty strings functions #303

merged 2 commits into from
Oct 17, 2021

Conversation

Kharhamel
Copy link
Collaborator

@Kharhamel Kharhamel commented Oct 16, 2021

TODO:

  • why substr isn't generated?

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2021

Codecov Report

Merging #303 (ae5df91) into master (c1748a0) will decrease coverage by 0.09%.
The diff coverage is 35.29%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #303      +/-   ##
============================================
- Coverage     48.24%   48.15%   -0.10%     
- Complexity      298      306       +8     
============================================
  Files            16       16              
  Lines           771      785      +14     
============================================
+ Hits            372      378       +6     
- Misses          399      407       +8     
Impacted Files Coverage Δ
generator/src/Method.php 62.18% <0.00%> (-1.61%) ⬇️
generator/src/Scanner.php 18.18% <0.00%> (-0.34%) ⬇️
generator/src/WritePhpFunction.php 0.00% <0.00%> (ø)
generator/src/DocPage.php 79.33% <66.66%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1748a0...ae5df91. Read the comment docs.

@Kharhamel Kharhamel changed the title WIP: Empty strings functions Empty strings functions Oct 17, 2021
@Kharhamel Kharhamel merged commit a5fa665 into master Oct 17, 2021
@homersimpsons homersimpsons deleted the emptyStringsFunctions branch March 27, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants