Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring in curl handles #322

Merged
merged 1 commit into from
Feb 1, 2022
Merged

bring in curl handles #322

merged 1 commit into from
Feb 1, 2022

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Jan 18, 2022

@mmoll
Copy link
Contributor Author

mmoll commented Jan 18, 2022

Not sure if this is correct, but I saw errors like

[...]
  90     Parameter #1 $handle of function Safe\curl_setopt expects resource, CurlHandle given.   
  92     Parameter #1 $handle of function Safe\curl_exec expects resource, CurlHandle given.     
  93     Parameter #1 $handle of function Safe\curl_getinfo expects resource, CurlHandle given.

also with #315.

@mmoll
Copy link
Contributor Author

mmoll commented Jan 27, 2022

now what? 🤔

@dbrekelmans
Copy link
Collaborator

Hi @mmoll, sorry I missed this PR.

Thanks for the effort so far.

The correct way to fix this, is to add these functions to generator/src/PhpStanFunctions/CustomPhpStanFunctionMap.php as was done in #315.
generated/curl.php is, as the directory suggest, generated and should not be edited manually.
This allows us to automatically update the generated files when the php docs are updated instead of manually updating all the changed functions on every php release.

If you could update the PR and make sure the build is green, I will gladly merge this!

@mmoll
Copy link
Contributor Author

mmoll commented Jan 27, 2022

Thanks @dbrekelmans, I hope it's coming back green now. 💚

@mmoll
Copy link
Contributor Author

mmoll commented Feb 1, 2022

should be fixed now

@codecov-commenter
Copy link

Codecov Report

Merging #322 (4784277) into master (c11fc2e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #322   +/-   ##
=========================================
  Coverage     48.48%   48.48%           
  Complexity      308      308           
=========================================
  Files            15       15           
  Lines           794      794           
=========================================
  Hits            385      385           
  Misses          409      409           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11fc2e...4784277. Read the comment docs.

@dbrekelmans dbrekelmans merged commit e19610c into thecodingmachine:master Feb 1, 2022
@dbrekelmans
Copy link
Collaborator

Thanks @mmoll!

@mmoll mmoll deleted the curlhandle branch February 1, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants