New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filesize method can return false but is not detected by Safe #54

Merged

moufmouf merged 2 commits into thecodingmachine:master from moufmouf:filesize

Oct 30, 2018

Member

moufmouf commented Oct 30, 2018

See #52

moufmouf added 2 commits

October 30, 2018 16:25


          Adding failing test for filesize


          Adding filesize method

ce87d9e

coveralls commented Oct 30, 2018

Pull Request Test Coverage Report for Build 114

0 of 0 changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.3%) to 31.02%

Files with Coverage Reduction	New Missed Lines	%
src/DocPage.php	3	90.41%

Totals
Change from base Build 112:	0.3%
Covered Lines:	152
Relevant Lines:	490

💛 - Coveralls

1 similar comment

coveralls commented Oct 30, 2018

Pull Request Test Coverage Report for Build 114

0 of 0 changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.3%) to 31.02%

Files with Coverage Reduction	New Missed Lines	%
src/DocPage.php	3	90.41%

Totals
Change from base Build 112:	0.3%
Covered Lines:	152
Relevant Lines:	490

💛 - Coveralls

moufmouf merged commit 31d2c13 into thecodingmachine:master

moufmouf deleted the filesize branch

October 30, 2018 16:49

moufmouf mentioned this pull request

Missing filesize function #52

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment