Call extension method in registry #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one was really tricky to find, took me ~3 hours 🤯 |
romm
force-pushed
the
bugfix/call-extension-method-in-registry
branch
from
7b8484e
to
639f166
Compare
The definition given to Symfony container would always call the method which creates a service in the registry. It led to unexpected behaviours that could not be perceived in current tests because the extension factories don't return a different value.
romm
force-pushed
the
bugfix/call-extension-method-in-registry
branch
from
639f166
to
ed7b57a
Compare
|
Impressive 👍 Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition given to Symfony container would always call the method
which creates a service in the registry. It led to unexpected behaviours
that could not be perceived in current tests because the extension
factories don't return a different value.