Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore - Fix indentation in generated methods 'find'/'findOne' #273

Merged

Conversation

dsavina
Copy link
Contributor

@dsavina dsavina commented Jun 10, 2022

There is an 8-space redundancy, as they were provided in the method body but also seem to be appended by the generator itself.

@codecov-commenter
Copy link

Codecov Report

Merging #273 (07907b0) into master (fbee465) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage     97.90%   97.90%           
  Complexity     1380     1380           
=========================================
  Files            61       61           
  Lines          4243     4243           
=========================================
  Hits           4154     4154           
  Misses           89       89           
Impacted Files Coverage Δ
src/Utils/BeanDescriptor.php 98.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbee465...07907b0. Read the comment docs.

@homersimpsons homersimpsons merged commit 1da21c2 into thecodingmachine:master Jun 10, 2022
@dsavina dsavina deleted the chore/codestyle-indentation branch September 12, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants