Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change in dependent version of m4tthumphrey/php-gitlab-api #8

Closed
wants to merge 4 commits into from
Closed

Conversation

flandera
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 37.012% when pulling 1593ac9 on flandera:1.2 into 9c1654a on thecodingmachine:1.2.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 37.012% when pulling 1593ac9 on flandera:1.2 into 9c1654a on thecodingmachine:1.2.

@coveralls
Copy link

coveralls commented Jun 14, 2017

Coverage Status

Coverage remained the same at 37.012% when pulling 527b7cd on flandera:1.2 into 9c1654a on thecodingmachine:1.2.

@coveralls
Copy link

coveralls commented Jun 14, 2017

Coverage Status

Coverage remained the same at 37.012% when pulling ffd9972 on flandera:1.2 into 9c1654a on thecodingmachine:1.2.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 37.012% when pulling d1bff02 on flandera:1.2 into 9c1654a on thecodingmachine:1.2.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 37.012% when pulling d1bff02 on flandera:1.2 into 9c1654a on thecodingmachine:1.2.

@moufmouf
Copy link
Member

Hey @flandera

Thanks for the PR. Actually, I cannot migrate to v8 of m4tthumphrey/php-gitlab-api this easily.
You may notice in the composer.json that I'm not actually using the "real" m4tthumphrey/php-gitlab-api but a fork I made myself to add missing methods (regarding fetching Gitlab artifacts).

I'm in the process of submitting a PR to m4tthumphrey/php-gitlab-api to add this support. When the PR is done and accepted, then I can switch to v8.

@flandera
Copy link
Author

Hello moufmouf,
actually I made this change, because when I attempted to perform install via composer, it throws an error when installing this dependecy package m4tthumprey/php-gitlab-api that this version doesn´t exist. I loooked into this repository and it seems, that last version was 7.15 an then 8. Version 7.16 which is in your composer json doesn´t exist. https://github.com/m4tthumphrey/php-gitlab-api/releases

@moufmouf
Copy link
Member

@flandera Indeed. You cannot install the washingmachine as a require-dev dependency or a global dependency (because of this issue with php-gitlab-api). I realize the README.md is at fault here.

Instead, you can do:

composer create-project thecodingmachine/washingmachine washingmachine ^1.2 --stability=dev

This will install the washingmachine in a separate directory.

When php-gitlab-api merges thiss PR: GitLabPHP/Client#196, we will be able to use wahingmachine as a require-dev dependency or a global dependency

@flandera
Copy link
Author

OK, thanks for the hint:-)

@moufmouf
Copy link
Member

Fixed the documentation in the soon to be merged commit: 795027e

@moufmouf
Copy link
Member

Closed by #9

@moufmouf moufmouf closed this Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants