-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] glob/crawl by symlink path, not real path #83
Comments
WIP at #84 |
@IanVS can you test against master branch and see if that works for you? |
Yep, I copied over the |
Will release v5.3.0 then |
@IanVS done. I changed the API a bit to be backwards compatible with v5 so check the docs to see how you can use it. |
Thanks. One small piece of unsolicited feedback, is that this might fall into the boolean trap. When reading |
I agree. I'll be making some breaking changes in v6.0 so this API is definitely not final. There's a lot of confusion in the current exposed methods so I will do some much needed renaming as well. |
As noted in #23 (comment), currently globs match against resolved symlink paths, not the symlink paths themselves. This is a bit counter-intuitive, and I think that the symlink paths should be matched and returned instead, perhaps with an option to return real paths instead.
The text was updated successfully, but these errors were encountered: