-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails on Android/Termux #155
Comments
Hm, apparently
but
baffling! I think android uses bionic which is a fork of musl as libc, so this would be congruent. |
Wait, we even handle this: let ioctl_request_type = match &env::var("CARGO_CFG_TARGET_ENV").expect("CARGO_CFG_TARGET_ENV")[..] {
"musl" => "libc::c_int",
_ => "libc::c_ulong",
}; of course, since we handle it like this instead of by autodetecting, it's bound to break when someone builds on illumos or any other non-BSD host. Cool. |
Can you try the current |
Sure. That fixes the error. Now it builds correctly. |
Bit me in <thecoshman/http#155>: musl (and, thus, bionic) takes an int! Kill the "POSIX says 'request' is int" comment; prior to Issue 7, ioctl() is shaded STREAMS, it's obsolescent in Issue 7, and gone completely in Issue 8. The POSIX interface has never been supported by Linux, and the common ioctl() interface has never existed in POSIX or the SUS. Note how the interface evolved in HISTORY. The NetBSD CVS has revision 1.1 date: 1993-03-21 10:45:37 +0100; author: cgd; state: Exp; branches: 1.1.1; Initial revision ---------------------------- revision 1.1.1.2 date: 1995-02-27 11:49:43 +0100; author: cgd; state: Exp; lines: +6 -6; from Lite ---------------------------- revision 1.1.1.1 date: 1993-03-21 10:45:37 +0100; author: cgd; state: Exp; lines: +0 -0; initial import of 386bsd-0.1 sources ---------------------------- and it's char * in 1.1.1.1 and 1.1.1.2 but ... in 1.1, so hell knows. Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Cc: Jakub Wilk <jwilk@jwilk.net> [alx: ffix] Signed-off-by: Alejandro Colomar <alx@kernel.org>
Released in |
Build fails on Termux with:
It seems the signature is different for Linux and Android. While Linux uses
::c_ulong
(u64
), Android uses::c_int
(i32
).The suggested fix works. I'll gladly propose a pull request if that is valid.
The text was updated successfully, but these errors were encountered: