Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notes | Multiple Categories deletion feature - cherry pick of pr 770 #858

Merged
merged 13 commits into from
Jun 29, 2024

Conversation

ArkadiK94
Copy link
Collaborator

Fixes Issue

cherry pick of pr #770 see there all the relevant comments

Changes proposed

Screenshots

Note to reviewers

done by @Jazzxe

Code of Conduct

  • By submitting this pull request, I confirm I've read and complied with the CoC 🖖

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

You can also join our Discord community.
Feel free to check out other cool repositories of the Thecyberworld.
Join the Thecyberworld GitHub Organisation by raising an issue (you will be sent an invitation).

Copy link

render bot commented Jun 11, 2024

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

🌟 Welcome to the community 🌟

  • If you would like to continue contributing to open source and would like to do it with an awesome inclusive community.
  • You should join our Discord chat and our GitHub Organisation.
  • We help and encourage each other to contribute to open source little and often 😄.
  • Any questions let us know.

@ArkadiK94
Copy link
Collaborator Author

I am changing to draft until it will be ready for review

@ArkadiK94 ArkadiK94 marked this pull request as draft June 25, 2024 20:12
what: remove the selected categories from redux, change from checked input
to div element.
why: user select categories locally , div element is enough
how: do some refactoring
@ArkadiK94 ArkadiK94 marked this pull request as ready for review June 28, 2024 18:32
@ArkadiK94 ArkadiK94 requested a review from kabir0x23 June 28, 2024 18:34
@ArkadiK94
Copy link
Collaborator Author

@kabir0x23 I fixed the comments that I left when I did cr in pr #770.
I also did some changes, could you please review it?

Recording.2024-06-28.213348.mp4

Copy link
Member

@kabir0x23 kabir0x23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good

@kabir0x23
Copy link
Member

@ArkadiK94 conflicts

@ArkadiK94
Copy link
Collaborator Author

nice, looks good

@kabir0x23 ok, so I handled conflict and I merge it

@ArkadiK94 ArkadiK94 merged commit 5298f92 into dev Jun 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants