Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add courses page #22

Closed
1 task done
kabir0x23 opened this issue Oct 14, 2022 · 24 comments · Fixed by #25 or #33
Closed
1 task done

[FEATURE] Add courses page #22

kabir0x23 opened this issue Oct 14, 2022 · 24 comments · Fixed by #25 or #33

Comments

@kabir0x23
Copy link
Member

kabir0x23 commented Oct 14, 2022

Detailed description

example link: https://www.thecyberhub.org/resources/courses

Context

This is a react native project
We have to make the same page like this

image

sourcecode: https://github.com/thecyberworld/thecyberhub.org

Possible implementation

No response

Additional information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@github-actions
Copy link

It's great having you contribute to this project

🌟 Welcome to the community 🌟

  • If you would like to continue contributing to open source and would like to do it with an awesome inclusive community.
  • You should join our Discord chat and our GitHub Organisation.
  • We help and encourage each other to contribute to open source little and often 😄.
  • Any questions let us know.

@Divyesh1511
Copy link

Hey, can you please elaborate on what to do with it, like course page is already there on the website so.

@kabir0x23
Copy link
Member Author

kabir0x23 commented Oct 14, 2022

Hey, can you please elaborate on what to do with it, like course page is already there on the website so.

this is a react-native project,
website is an example,
We have to create a same page like this on app aswell

@sanketshevare
Copy link
Contributor

can i look into this?

@kabir0x23
Copy link
Member Author

can i look into this?

Yes sure.

@sanketshevare
Copy link
Contributor

Thank you!
I already done this is this ok?
Screenshot from 2022-10-19 19-01-36

@kabir0x23
Copy link
Member Author

Thank you! I already done this is this ok? Screenshot from 2022-10-19 19-01-36

yes somewhat
but we have to make the card different from the events:
components and CSS of courses card has already given

@sanketshevare
Copy link
Contributor

Ok i'll make it and this courses styles are same as website right?

@kabir0x23
Copy link
Member Author

kabir0x23 commented Oct 19, 2022

Ok i'll make it and this courses styles are same as website right?

yeah and you can find the CSS components from here.
https://github.com/thecyberworld/thecyberhub.org

@sanketshevare
Copy link
Contributor

Ok thank you!

@sanketshevare
Copy link
Contributor

Can you assign this issue to me ?

@kabir0x23
Copy link
Member Author

Can you assign this issue to me ?

already assigned
image

@sanketshevare
Copy link
Contributor

Thanks 👍

@sanketshevare
Copy link
Contributor

Hey @kabir0x23 I have done this like on website and if user clock on upper image it will go to youtube video and for lower image it will go to youtube channel is this okay? And if there are any changes let me know

Screenshot_2022-10-20-18-52-46-96_f73b71075b1de7323614b647fe394240.jpg

@kabir0x23
Copy link
Member Author

Awesome

And for some changes:

  • You can include the image and title in the youtube video link
  • Channel image and name under channel link.

@sanketshevare
Copy link
Contributor

Yes that's already done ✅

@kabir0x23
Copy link
Member Author

Yes that's already done ✅

Super 🔥

@sanketshevare
Copy link
Contributor

Can you review the pull request it has a conflict?

@kabir0x23
Copy link
Member Author

Great, we will review your PR and merge very soon. until then/If you are looking to contribute more to the open-source, then you can give a look at other open issues or can create issues.

Thank you 😄.

@sanketshevare
Copy link
Contributor

Okay 😀

@sanketshevare
Copy link
Contributor

Do you have any design ideas about settings page?

@kabir0x23
Copy link
Member Author

Do you have any design ideas about settings page?

Yeah, something like:

  • dark mode on/off
  • versions

What we can add more?

@sanketshevare
Copy link
Contributor

Like feedback section and help section

This was referenced Oct 22, 2022
@sanketshevare
Copy link
Contributor

Hey @kabir0x23 can you assign settings page issue (feature) to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment