Fixed 'too many open file' errors due to not closing test files

thedarkone · Dec 30, 2008 · 761decf · 761decf
1 parent e345764
commit 761decf
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 0 deletions.
diff --git a/test/attachment_test.rb b/test/attachment_test.rb
@@ -81,6 +81,8 @@ class AttachmentTest < Test::Unit::TestCase
       @dummy.avatar = @file
     end
 
+    teardown { @file.close }
+
     should "make sure that they are interpolated correctly" do
       assert_equal "1024.omg/1024-bbq/1024what/000/001/024.wtf", @dummy.avatar.path
     end
@@ -99,6 +101,8 @@ class AttachmentTest < Test::Unit::TestCase
       @dummy.avatar = @file
     end
 
+    teardown { @file.close }
+
     should "return the proper path" do
       temporary_rails_env(@rails_env) {
         assert_equal "#{@rails_env}/#{@id}.png", @dummy.avatar.path
@@ -298,6 +302,8 @@ def do_after_all; end
                                  "5k.png"), 'rb')
     end
 
+    teardown { @file.close }
+
     should "raise if there are not the correct columns when you try to assign" do
       @other_attachment = Paperclip::Attachment.new(:not_here, @instance)
       assert_raises(Paperclip::PaperclipError) do
@@ -464,6 +470,8 @@ def do_after_all; end
       @file = File.new(File.join(File.dirname(__FILE__), "fixtures", "5k.png"), 'rb')
     end
 
+    teardown { @file.close }
+
     should "not error when assigned an attachment" do
       assert_nothing_raised { @dummy.avatar = @file }
     end

diff --git a/test/integration_test.rb b/test/integration_test.rb
@@ -29,6 +29,8 @@ class IntegrationTest < Test::Unit::TestCase
       assert @dummy.save
     end
 
+    teardown { @file.close }
+
     should "create its thumbnails properly" do
       assert_match /\b50x50\b/, `identify "#{@dummy.avatar.path(:thumb)}"`
     end
@@ -61,6 +63,8 @@ class IntegrationTest < Test::Unit::TestCase
       @dummy.avatar = @file
     end
 
+    teardown { @file.close }
+
     context "when saved" do
       setup do
         @dummy.save

diff --git a/test/iostream_test.rb b/test/iostream_test.rb
@@ -14,6 +14,8 @@ class IOStreamTest < Test::Unit::TestCase
       @file = File.new(File.join(File.dirname(__FILE__), "fixtures", "5k.png"), 'rb')
     end
 
+    teardown { @file.close }
+
     context "that is sent #stream_to" do
 
       context "and given a String" do

diff --git a/test/paperclip_test.rb b/test/paperclip_test.rb
@@ -72,6 +72,8 @@ class PaperclipTest < Test::Unit::TestCase
       @file = File.new(File.join(FIXTURES_DIR, "5k.png"), 'rb')
     end
 
+    teardown { @file.close }
+
     should "not error when trying to also create a 'blah' attachment" do
       assert_nothing_raised do
         Dummy.class_eval do

diff --git a/test/storage_test.rb b/test/storage_test.rb
@@ -82,6 +82,8 @@ class StorageTest < Test::Unit::TestCase
         @dummy.avatar = @file
       end
 
+      teardown { @file.close }
+
       should "not get a bucket to get a URL" do
         @dummy.avatar.expects(:s3).never
         @dummy.avatar.expects(:s3_bucket).never
@@ -144,6 +146,8 @@ class StorageTest < Test::Unit::TestCase
         @dummy.avatar = @file
       end
 
+      teardown { @file.close }
+
       context "and saved" do
         setup do
           @s3_mock     = stub
@@ -190,6 +194,8 @@ class StorageTest < Test::Unit::TestCase
           @dummy.avatar = @file
         end
 
+        teardown { @file.close }
+
         should "still return a Tempfile when sent #to_io" do
           assert_equal Tempfile, @dummy.avatar.to_io.class
         end

diff --git a/test/thumbnail_test.rb b/test/thumbnail_test.rb
@@ -35,6 +35,8 @@ class ThumbnailTest < Test::Unit::TestCase
       @file = File.new(File.join(File.dirname(__FILE__), "fixtures", "5k.png"), 'rb')
     end
 
+    teardown { @file.close }
+
     [["600x600>", "434x66"],
      ["400x400>", "400x61"],
      ["32x32<", "434x66"]