Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add (untested) slow path and make performance test compile #27

Merged
merged 29 commits into from
Nov 30, 2023
Merged

Add (untested) slow path and make performance test compile #27

merged 29 commits into from
Nov 30, 2023

Conversation

solimantwali
Copy link
Collaborator

@solimantwali solimantwali commented Nov 30, 2023 •
edited
Loading

  • Rename utilities to utility_lib
  • Debug performance tests

thedavidchu
thedavidchu requested changes Nov 30, 2023
View reviewed changes
Copy link
Owner

@thedavidchu thedavidchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the algorithm, I mostly checked for code hygiene.

Might as well merge it now with a broken algorithm so that we can run our perf tests sooner rather than later #️⃣approximatecomputing

src/CMakeLists.txt Outdated Show resolved Hide resolved
src/parallel/CMakeLists.txt Outdated Show resolved Hide resolved
src/parallel/CMakeLists.txt Outdated Show resolved Hide resolved
src/parallel/include/parallel/parallel.hpp Outdated Show resolved Hide resolved
src/parallel/include/parallel/parallel.hpp Outdated Show resolved Hide resolved
src/parallel/parallel.cpp Outdated Show resolved Hide resolved
src/parallel/parallel.cpp Outdated Show resolved Hide resolved
src/parallel/parallel.cpp Outdated Show resolved Hide resolved
src/parallel/parallel.cpp Outdated Show resolved Hide resolved
src/parallel/parallel.cpp Outdated Show resolved Hide resolved
@thedavidchu thedavidchu changed the title Add slow path and performance test Add (untested) slow path and make performance test compile Nov 30, 2023
solimantwali and others added 17 commits November 30, 2023 11:32
@solimantwali @thedavidchu
Update src/CMakeLists.txt
4e3f085 
Co-authored-by: David Chu <45278895+thedavidchu@users.noreply.github.com>
@solimantwali @thedavidchu
Update src/parallel/CMakeLists.txt
2e22df8 
Co-authored-by: David Chu <45278895+thedavidchu@users.noreply.github.com>
@solimantwali @thedavidchu
Update src/parallel/CMakeLists.txt - duplicated code
a042a5c 
Co-authored-by: David Chu <45278895+thedavidchu@users.noreply.github.com>
@solimantwali @thedavidchu
Update src/parallel/include/parallel/parallel.hpp - utility.hpp inste…
b73ba81 
…ad of utilities.hpp

Co-authored-by: David Chu <45278895+thedavidchu@users.noreply.github.com>
@solimantwali
add comment on parallel.hpp to explain why we would want the static a…
12f40cc 
…ssert
@solimantwali @thedavidchu
Update src/parallel/parallel.cpp - format of "Fast-path" comment
bc41be5 
Co-authored-by: David Chu <45278895+thedavidchu@users.noreply.github.com>
@solimantwali
add more descriptive comment to fast-path update TODO comment on para…
2f69724 
…llel.cpp
@solimantwali @thedavidchu
Update src/parallel/parallel.cpp - more descriptive slow path comment…
0161992 
… in insert in parallel.cppcomment for

Co-authored-by: David Chu <45278895+thedavidchu@users.noreply.github.com>
@solimantwali @thedavidchu
Update src/parallel/parallel.cpp - code style
4b5dbb4 
Co-authored-by: David Chu <45278895+thedavidchu@users.noreply.github.com>
@solimantwali @thedavidchu
Update src/parallel/parallel.cpp - capitalized comment
31d994b 
Co-authored-by: David Chu <45278895+thedavidchu@users.noreply.github.com>
@solimantwali @thedavidchu
Update src/parallel/parallel.cpp - remove TODO comment
346e91b 
Co-authored-by: David Chu <45278895+thedavidchu@users.noreply.github.com>
@solimantwali @thedavidchu
Update src/parallel/parallel.cpp - comment grammar
04fb323 
Co-authored-by: David Chu <45278895+thedavidchu@users.noreply.github.com>
@solimantwali @thedavidchu
Update src/parallel/parallel.cpp - atomic_load_key_val
31c324c 
Co-authored-by: David Chu <45278895+thedavidchu@users.noreply.github.com>
@solimantwali @thedavidchu
Update src/parallel/parallel.cpp - comment format
c00c0aa 
Co-authored-by: David Chu <45278895+thedavidchu@users.noreply.github.com>
@solimantwali @thedavidchu
Apply suggestions from code review
ddfdfd6 
Co-authored-by: David Chu <45278895+thedavidchu@users.noreply.github.com>
@solimantwali
CMake changes and other small changes
ba898bd 
* utilities -> utility
* changed traces folder to trace
* changed generate_random_trace to generate_random_traces
@solimantwali
Add small changes per david's review
42e6bb1 
* move hash function source comment from sequential.hpp to utility.cpp
* alphabetize includes in performance_test/main.cpp
* add more descriptive comment for shifting entries in remove() in
  parallel.cpp
* use capacity_with_buffer in find_next_index_lock()
solimantwali
solimantwali commented Nov 30, 2023
View reviewed changes
Copy link
Collaborator Author

@solimantwali solimantwali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All conversations resolved

thedavidchu
thedavidchu approved these changes Nov 30, 2023
View reviewed changes
Copy link
Owner

@thedavidchu thedavidchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (on the condition it compiles with the changes!)

@solimantwali solimantwali merged commit 6fb49bf into main Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedavidchu thedavidchu thedavidchu approved these changes

@griffinandrew griffinandrew Awaiting requested review from griffinandrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@solimantwali @thedavidchu