Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lang-Attribute note #86

Closed
MarcoHengstenberg opened this issue Oct 25, 2017 · 7 comments
Closed

Add lang-Attribute note #86

MarcoHengstenberg opened this issue Oct 25, 2017 · 7 comments

Comments

@MarcoHengstenberg
Copy link

It would make a lot of sense to tell developers that a lang-Attribute is always needed in the HTML element (first section with doctype).
The point is that screenreaders will automatically switch their language-mode when a lang attribute is present. That way the reader will not announce in a different language than present on the page.

@thedaviddias
Copy link
Owner

Hi @MarcoHengstenberg, I'm not sure if I clearly understand your request... Did you saw that the langis in the next section?

@MarcoHengstenberg
Copy link
Author

MarcoHengstenberg commented Oct 25, 2017

Oh. Nope, I didn't see that. After not seeing the lang-Attribute on the <html> element I searched the readme for "lang-attribute" to no avail.
Then I'd suggest renaming that section to lang-Attribute instead of Language tag. :)

@thedaviddias
Copy link
Owner

Voilà :)

@MarcoHengstenberg
Copy link
Author

Merci Monsieur 😁

@MarcoHengstenberg
Copy link
Author

Language attribute: High The language tag of your website is specified and related to the language of the current page.

Oh noes.

@thedaviddias
Copy link
Owner

@MarcoHengstenberg better now?

@MarcoHengstenberg
Copy link
Author

Wonderful! Many thanks. :)

thedaviddias added a commit that referenced this issue Nov 15, 2017
qirh pushed a commit to qirh/Front-End-Checklist-AR that referenced this issue Dec 5, 2017
qirh pushed a commit to qirh/Front-End-Checklist-AR that referenced this issue Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants