Bugfixes for v1.1.0 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jul 23, 2021
•
ghost
commented
- Add MATLAB's scientific dataset packages.
- Undeprecate generic property names.
- Fix function boundaries in lookbehind patterns.
- Fix import module highlighting
- Make keyword control end tokens consistent
- Fix readwrite injection selector
Also fix function boundaries in lookbehind patterns
|
Thanks for this @4086606 Any chance you can review and merge @rlivings39 I can handle the version publishing if needed. |
|
Is this one ready for review @sndst00m? |
|
Yup |
|
@rlivings39 any chance you have availability? |
rlivings39
approved these changes
Aug 25, 2021
|
Was out on vacation. This looks good to me. Merged |
ghost
deleted the
|
Thanks, all! I'll work on the release now. It's an important update. Going to bump the semver minor. |
1 similar comment
|
Thanks, all! I'll work on the release now. It's an important update. Going to bump the semver minor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.