fixed model unbind when model is also part of a collection #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther models have binding
|
Hi there - happy new years! Wanted to check in with you in case you have a chance to review this pull request. I just got bit by incorporating the unpatched 0.9.0 into my project and debugging the same issue that I created this pull request for :) Best, |
|
Thanks. Merged in 0.9.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling unbind(this), I fixed a bug due to a missing 'else' where even if the view had a model, if the model was also part of a collection, all other collection models would be unbound. I don't think this is the correct behavior since different views that are concurrently showing may decide to change which model they are displaying. Without this fix, if one view did an unbind(), retrieved a new model, and then called bind(), then any other views would be unbound as well!
Please review,
Kimon