fixed model unbind when model is also part of a collection #182

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

kinergy commented Nov 6, 2013

When calling unbind(this), I fixed a bug due to a missing 'else' where even if the view had a model, if the model was also part of a collection, all other collection models would be unbound. I don't think this is the correct behavior since different views that are concurrently showing may decide to change which model they are displaying. Without this fix, if one view did an unbind(), retrieved a new model, and then called bind(), then any other views would be unbound as well!

Please review,
Kimon

Contributor

kinergy commented Dec 31, 2013

Hi there - happy new years!

Wanted to check in with you in case you have a chance to review this pull request. I just got bit by incorporating the unpatched 0.9.0 into my project and debugging the same issue that I created this pull request for :)

Best,
Kimon

Owner

thedersen commented Jan 8, 2014

Thanks. Merged in 0.9.1

thedersen closed this Jan 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment