Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix current password validation #98

Merged
merged 1 commit into from Jul 21, 2023

Conversation

thinkverse
Copy link
Contributor

This PR fixes the current password validation for the Tallstack theme and others.

Laravel renamed1 the password rule in Laravel 9 to current_password2.

Footnotes

  1. https://laravel.com/docs/9.x/validation#rule-password

  2. https://laravel.com/docs/9.x/validation#rule-current-password

@bobbyiliev bobbyiliev merged commit a8fac36 into thedevdojo:main Jul 21, 2023
1 check passed
@thinkverse thinkverse deleted the fix-security-settings branch July 21, 2023 23:45
@soyraro
Copy link

soyraro commented Jul 24, 2023

I have installed wave from scratch with no errors and get "These credentials do not match our records." msg trying to signin using admin@admin.com / admin. ¿Is this related?

@thinkverse
Copy link
Contributor Author

thinkverse commented Jul 24, 2023

Is this related?

No, this PR doesn't mess with the seeder or the login process, and the password for the admin user is password not admin. It's written in the documentation1.

Footnotes

  1. https://wave.devdojo.com/docs/features/authentication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants