File validation not working? #24

nmsobri · 2018-02-19T10:05:04Z

Hey adam..

I think the form validation is not working when the rules is optional (no required)

func handler(w http.ResponseWriter, r *http.Request) {
	rules := govalidator.MapData{
                //Notice this rules is optional
		"file:photo": []string{"ext:jpg,png", "size:2000000", "mime:jpg,png"},
	}

	messages := govalidator.MapData{
		"file:photo": []string{"ext:Only jpg/png is allowed", "size:Maximux size is 2Mb"},
	}

	opts := govalidator.Options{
		Request: r,     // request object
		Rules:   rules, // rules map,
		Messages: messages,
	}

	v := govalidator.New(opts)
	e := v.Validate()
	err := map[string]interface{}{"validationError": e}
	w.Header().Set("Content-type", "applciation/json")
	json.NewEncoder(w).Encode(err)
}

Eventhough im not uploading any file, the validation still run through yielding me to Only jpg/png is allowed

Regarding this line:
https://github.com/thedevsaddam/govalidator/blob/master/validator.go#L95

Even though there is no uploaded file, file is still not nil
I think the correct way should be

if strings.HasPrefix(field, "file:") {
	fld := strings.TrimPrefix(field, "file:")
	file, fileHeader, _ := v.Opts.Request.FormFile(fld)
	if fileHeader.Filename  != "" {
		validateFiles(v.Opts.Request, fld, rule, msg, errsBag)
		validateCustomRules(fld, rule, msg, file, errsBag)
	} else {
		validateCustomRules(fld, rule, msg, nil, errsBag)
	}
}

Some additional info:
Golang v1.10
I'm entirely not sure prior to v1.10 whether its working or not

The text was updated successfully, but these errors were encountered:

thedevsaddam · 2018-02-19T11:59:46Z

Go version:

go version go1.10 darwin/amd64

Govalidator version:

v1.8

Code

package main

import (
	"encoding/json"
	"fmt"
	"net/http"

	"github.com/thedevsaddam/govalidator"
)

func handler(w http.ResponseWriter, r *http.Request) {
	rules := govalidator.MapData{
		"file:photo": []string{"ext:jpg,png", "size:10000", "mime:jpg,png"},
	}

	messages := govalidator.MapData{
		"file:photo": []string{"ext:Only jpg/png is allowed", "required:Photo is required"},
	}

	opts := govalidator.Options{
		Request:  r,     // request object
		Rules:    rules, // rules map,
		Messages: messages,
	}
	v := govalidator.New(opts)
	e := v.Validate()
	err := map[string]interface{}{"validationError": e}
	w.Header().Set("Content-type", "applciation/json")
	json.NewEncoder(w).Encode(err)
}

func main() {
	http.HandleFunc("/", handler)
	fmt.Println("Listening on port: 9999")
	http.ListenAndServe(":9999", nil)
}

Response:

Without providing any file

Could you please provide me more details. @slier81 It seem's okay

nmsobri · 2018-02-21T02:07:34Z

@thedevsaddam ill double check, will inform u afterward

nmsobri · 2018-02-21T03:13:18Z

@thedevsaddam

I can assure you that the bug really exist.
I dont know why you didnt get the error when u run it through postman
Here is sample code you can quickly test

package main

import (
	"fmt"
	"net/http"
	"text/template"
	"github.com/thedevsaddam/govalidator"
)

func handler(w http.ResponseWriter, r *http.Request) {

	if r.Method == "GET" {
		t, _ := template.New("foo").Parse(`
			<html><form action="/" method="post" enctype="multipart/form-data">
				<input type="file" name="photo">
				<input type="submit">
    		        </form></html>
		`)

		t.Execute(w, nil)

	} else {
		rules := govalidator.MapData{
			"file:photo": []string{"ext:jpg,png", "size:10000000"},
		}

		messages := govalidator.MapData{
			"file:photo": []string{"ext:Only jpg/png is allowed", "required:Photo is required"},
		}

		opts := govalidator.Options{
			Request:  r,     // request object
			Rules:    rules, // rules map,
			Messages: messages,
		}
		v := govalidator.New(opts)
		e := v.Validate()
		err := map[string]interface{}{"validationError": e}
		fmt.Fprint(w, err)
	}
}

func main() {
	http.HandleFunc("/", handler)
	fmt.Println("Listening on port: 9999")
	http.ListenAndServe(":9999", nil)
}

When u submit the form without uploading any file, u will get :
map[validationError:map[photo:[Only jpg/png is allowed]]]

Another bug, when u explicitly put required rules and submit the form without uploading any files, the required rules seems not being apply.It will return:
map[validationError:map[photo:[Only jpg/png is allowed]]] like the one without required rules

The validation seem to be working before this..When i pull the latest code from your repos, it break everything. #18 possible cause?

thedevsaddam · 2018-02-21T08:15:44Z

@slier81 Hope it'll work now. Please check from master branch and if it's okay then I'll tag this commit as v1.9

nmsobri · 2018-02-21T08:54:57Z

@thedevsaddam eh i thought u waiting for my PR? nvm ill check it, and confirm with u afterwards

nmsobri · 2018-02-21T09:25:05Z

@thedevsaddam Yes everything is working as expected.Thank you for your hard work..You can tag this commit as v1.9 and close this issue

thedevsaddam added a commit that referenced this issue Feb 21, 2018

Fix: issue #24

53a5c55

thedevsaddam added a commit that referenced this issue Feb 21, 2018

Fix: issue #24

fd13e13

thedevsaddam closed this as completed Feb 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

File validation not working? #24

File validation not working? #24

nmsobri commented Feb 19, 2018

thedevsaddam commented Feb 19, 2018 •

edited

nmsobri commented Feb 21, 2018

nmsobri commented Feb 21, 2018 •

edited

thedevsaddam commented Feb 21, 2018

nmsobri commented Feb 21, 2018

nmsobri commented Feb 21, 2018

File validation not working? #24

File validation not working? #24

Comments

nmsobri commented Feb 19, 2018

thedevsaddam commented Feb 19, 2018 • edited

Go version:

Govalidator version:

Code

Response:

nmsobri commented Feb 21, 2018

nmsobri commented Feb 21, 2018 • edited

thedevsaddam commented Feb 21, 2018

nmsobri commented Feb 21, 2018

nmsobri commented Feb 21, 2018

thedevsaddam commented Feb 19, 2018 •

edited

nmsobri commented Feb 21, 2018 •

edited