Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rules deletion on validation #31

Merged
merged 1 commit into from
May 2, 2018

Conversation

bluele
Copy link
Contributor

@bluele bluele commented Apr 27, 2018

Hi, @thedevsaddam .

It seems that fields of Options.Rule are deleted in some case, so Options.Rule cannot be used more than once. This behavior seems a bit inconvenient, so I'd like to fix it. What do you think?

@coveralls
Copy link

coveralls commented Apr 27, 2018

Coverage Status

Coverage increased (+0.07%) to 88.052% when pulling 263cfdd on bluele:remove-rules-deletion into 738a97e on thedevsaddam:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 88.052% when pulling 263cfdd on bluele:remove-rules-deletion into 738a97e on thedevsaddam:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 88.052% when pulling 263cfdd on bluele:remove-rules-deletion into 738a97e on thedevsaddam:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 88.052% when pulling 263cfdd on bluele:remove-rules-deletion into 738a97e on thedevsaddam:master.

@thedevsaddam thedevsaddam merged commit 8692f06 into thedevsaddam:master May 2, 2018
thedevsaddam pushed a commit that referenced this pull request May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants