New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed support of negative numbers in `numeric` rule #52

Merged

thedevsaddam merged 1 commit into thedevsaddam:dev from maoueh:fix/numeric-negative

Jan 10, 2019

Contributor

maoueh commented Jan 10, 2019

The numeric rule was not handling negative numbers correctly as the Numeric regexp was not accepting negative numbers which is valid.

Fixed that and added a bunch of test cases around negative numbers for numeric, numeric_between, min and max.

coveralls commented Jan 10, 2019

Coverage increased (+0.1%) to 88.985% when pulling 6ce2f8a on maoueh:fix/numeric-negative into 8625cae on thedevsaddam:master.

4 similar comments

coveralls commented Jan 10, 2019

Coverage increased (+0.1%) to 88.985% when pulling 6ce2f8a on maoueh:fix/numeric-negative into 8625cae on thedevsaddam:master.

coveralls commented Jan 10, 2019

Coverage increased (+0.1%) to 88.985% when pulling 6ce2f8a on maoueh:fix/numeric-negative into 8625cae on thedevsaddam:master.

coveralls commented Jan 10, 2019

Coverage increased (+0.1%) to 88.985% when pulling 6ce2f8a on maoueh:fix/numeric-negative into 8625cae on thedevsaddam:master.

coveralls commented Jan 10, 2019

Coverage increased (+0.1%) to 88.985% when pulling 6ce2f8a on maoueh:fix/numeric-negative into 8625cae on thedevsaddam:master.

coveralls commented Jan 10, 2019 •

edited

Loading

Coverage increased (+0.1%) to 88.985% when pulling 8bcee46 on maoueh:fix/numeric-negative into 8625cae on thedevsaddam:master.

Owner

thedevsaddam commented Jan 10, 2019

Can you please send the PR to dev branch?

Contributor Author

maoueh commented Jan 10, 2019

Yeah sure.


          Fixed support of negative numbers in numeric rule

8bcee46

The `numeric` rule was not handling negative numbers correctly as the
`Numeric` regexp was not accepting negative numbers which is valid.

Fixed that and added a bunch of test cases around negative numbers for
`numeric`, `numeric_between`, `min` and `max`.

maoueh force-pushed the fix/numeric-negative branch from 6ce2f8a to 8bcee46 Compare

January 10, 2019 05:27

Contributor Author

maoueh commented Jan 10, 2019

Rebased & updated.

Contributor Author

maoueh commented Jan 10, 2019

While you are not far, I tried validating a query parameters with numeric, min:1, however, the since query param is a string, it validates against the length of string instead of its value.

I see two possibilities to workaround that:

Update numeric_between to accept unbound max/min (numeric_between:1, and numeric_between:,10.
Add numeric_min and numeric_max

What do you think? Other ideas?

maoueh changed the base branch from master to dev

January 10, 2019 05:31

thedevsaddam merged commit e54c6c0 into thedevsaddam:dev

maoueh deleted the fix/numeric-negative branch

January 10, 2019 05:38

Contributor Author

maoueh commented Jan 10, 2019

I went with numeric_between way, see #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment