Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal overlay not disappearing #184

Closed
jekelija opened this issue Jan 8, 2018 · 5 comments
Closed

Modal overlay not disappearing #184

jekelija opened this issue Jan 8, 2018 · 5 comments

Comments

@jekelija
Copy link

jekelija commented Jan 8, 2018

I am 100% certain that I am doing something wrong, but could not tell you what. So this is less of a bug and more of a question. My modal overlay is not disappearing on an element. In order to get it to disappear, i had to comment out the setTimeout in the modal hide function, i.e.:
// setTimeout(function(){
hasClass(modal,'fade') ? emulateTransitionEnd(modal, triggerHide) : triggerHide();
// }, supportTransitions ? 150 : 0);

I'm not an expert, but it seems like adding the transition end after 150ms won't work b/c the transition itself only takes 150ms, which means depending on order of operation, the transition end listener won't get added until after the transition completes and the transition end event was already fired.

However, I assume I'm doing something wrong, since I can't seem to find anyone else having this issue. Please advise.

@thednp
Copy link
Owner

thednp commented Jan 8, 2018

You might have to check HTML validation and consistency with Bootstrap markup.

@thednp thednp closed this as completed Jan 8, 2018
@jekelija
Copy link
Author

jekelija commented Jan 8, 2018

I believe its valid, b/c it was working with bootstrap. All i did was switch an existing modal over from jquery to bootstrap native. And the overlay stopped disappearing. Would you like me to post a sample?

@thednp
Copy link
Owner

thednp commented Jan 8, 2018

Sure.

@jekelija
Copy link
Author

jekelija commented Jan 8, 2018

And i'm a damn fool. I think. Now I can't reproduce. Ignore me.

@thednp
Copy link
Owner

thednp commented Jan 9, 2018

It's ok, happens all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants