Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The file system watcher should ignore changes in a .git directory #148

Closed
torhovland opened this issue Mar 20, 2021 · 2 comments · Fixed by #153
Closed

The file system watcher should ignore changes in a .git directory #148

torhovland opened this issue Mar 20, 2021 · 2 comments · Fixed by #153
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed ready Ready to be implemented

Comments

@torhovland
Copy link

Whenever I commit and push code (or do anything else that involves Git), a build is triggered due to the file system watcher picking up action in the .git directory:

Mar 20 09:03:52.476  INFO change detected in "/home/project/.git/objects/8e/4445608e3b1ff19e4f9e00566ecd5c6228ca45"
Mar 20 09:03:52.476  INFO 📦 starting build

Mar 20 09:03:54.193  INFO change detected in "/home/project/.git/index"
Mar 20 09:03:54.194  INFO 📦 starting build

Mar 20 09:04:04.494  INFO change detected in "/home/project/.git/objects/3c"
Mar 20 09:04:04.494  INFO 📦 starting build

Mar 20 09:04:06.126  INFO change detected in "/home/project/.git/objects/3c/133d81788a53e646533b990a526d816c28e7dc"
Mar 20 09:04:06.126  INFO 📦 starting build
@thedodd thedodd added the enhancement New feature or request label Mar 22, 2021
@thedodd
Copy link
Member

thedodd commented Mar 22, 2021

Awesome. Yea, this is one of those paths which we can pretty safely add to the ignore list by default. Probably a one-line change in the config code.

@thedodd thedodd added good first issue Good for newcomers help wanted Extra attention is needed ready Ready to be implemented labels Mar 22, 2021
thedodd added a commit that referenced this issue Mar 24, 2021
@thedodd
Blacklist the .git folder.
5201fd8 
Definitely going to keep this issue simple. Lots more we could do here
with automatically ignoring all of the contents of a repo's `.gitignore`
and such, however folks can still ignore these in their config quite
easily.

closes #148
thedodd added a commit that referenced this issue Mar 24, 2021
@thedodd
Blacklist the .git folder.
8046da8 
Definitely going to keep this issue simple. Lots more we could do here
with automatically ignoring all of the contents of a repo's `.gitignore`
and such, however folks can still ignore these in their config quite
easily.

closes #148
@thedodd thedodd mentioned this issue Mar 24, 2021
Merged
2 tasks
@thedodd
Copy link
Member

thedodd commented Mar 25, 2021

Fixed by #153! And should be released shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed ready Ready to be implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Blacklist the .git folder. trunk-rs/trunk
2 participants
@torhovland @thedodd