Inject phrases function from outside #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I upload |
theeluwin
approved these changes
Aug 28, 2020
|
Thank you for the contribution. Using external tokenizer was in the plan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To deploy this system into AWS Lambda, I should inject
phrasesfunction from the outside because AWS Lambda doesn't support two runtimes in an one Lambda instance. I will makephrases-apias another stack and useApiPhraserintextrankr-apistack.I think the code quality of this PR is not so good because I don't want to touch many things as possible as I can. So please suggest better design you think.
Thanks!