Disconnect expired clients on release #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After moving an app to use Tornadis, we started seeing connections leak. We were using a pool of a limited size with a connection timeout. Since the time delats are on connection state changes are calculated in seconds, we tracked the connection leak down to ``ClientPool.release_client``. We found it possible for a client's connection to expire while the client is in use most likely due to rounding to whole seconds when calcuating a client's freshness. Since the client is never appended back to the pool allowing it to be disconnected [here](https://github.com/thefab/tornadis/blob/master/tornadis/pool.py#L62). This change checks if the client is still connected if it's not placed back into the pool and disconnects it.
|
👍 need this. |
|
just great !!! many thanks !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving an app to use Tornadis, we started seeing connections leak.
We were using a pool of a limited size with a connection timeout. Since
the time deltas on connection state changes are calculated in
seconds, we tracked the connection leak down to
ClientPool.release_client. We found it possible for a client'sconnection to expire while the client is in use most likely due to
rounding to whole seconds when calculating a client's freshness.
The client is never appended back to the pool allowing it to be
disconnected
here.
This change checks if the client is still connected if it's not placed
back into the pool and disconnects it.