Fixes #9299 - Add wimboot template to WAIK #148
Conversation
| menu default | ||
| menu label Wimboot via pxelinux | ||
| com32 linux.c32 <%= @kernel %> | ||
| append initrdfile=<%= @initrd %>,<%= @host.operatingsystem.bootfile(@host.arch,:bcd) %>,<%= @host.operatingsystem.bootfile(@host.arch,:bootsdi) %>,<%= @host.operatingsystem.bootfile(@host.arch,:bootwim) %> |
There was a problem hiding this comment.
Nitpick: generally we prefer line endings at the end of the file.
|
I don't have knowledge of windows and pxelinux, so unless someone else can provide some insight I'm tempted to trust you and merge it. |
|
It can't be worse than what we have 😄 |
|
Great, thank you. |
| default wimboot | ||
| label wimboot | ||
| menu default | ||
| menu label Wimboot via pxelinux |
There was a problem hiding this comment.
I recall PXELinux had some issue with two menu items, but not sure of the details. Does this work?
There was a problem hiding this comment.
I added some changes. The idea that it should render to something like that:
default wimbootpe
label wimbootpe
menu default
menu label Wimboot via pxelinux
com32 linux.c32 boot/windows-x64/wimboot
append initrdfile=boot/windows-x64/bootmgr,boot/windows-x64/bcd,boot/windows-x64/boot.sdi,boot/windows-x64/boot.wim
|
Can we please merge this? Is there anything else required? theforeman/smart-proxy#257 & theforeman/foreman#2143 are ready. |
|
I have 2 inline notes, if you can address those I think it can be merged. |
AutomationD
changed the title
|
@kireevco ping? As said in IRC, I think/hope this could work completely wihout menu at all. |
|
I'm out these 2 days. I'll test it without menus next week . Sent from my iPhone
|
|
take your time :) |
|
@kireevco could you please reopen against develop branch? we renamed master to develop since we started branching this repo per foreman releases |
Adding a windows template that works with wimboot. If anyone was able to make the old template work without WDS - let me know.