Fixes #15360 - UserData default should Patch the system and reboot #283
Conversation
| post: [] | ||
| tries: 10 | ||
|
|
||
| <% unless @host.param_false?('reboot') -%> |
There was a problem hiding this comment.
I'm worried about this behaviour change, and wonder if the default should be not to upgrade/reboot and have it opt-in?
There was a problem hiding this comment.
OK, I agree with that. Seems like more will not want this in a cloud environment.
|
Also documentation for these parameters would be great. |
|
Where would you like documentation? At the top of the template, with a line for each param, like others? |
|
Yep, top of the template please. |
|
hmm other templates use dasherized params, while this one uses underscore. |
|
It's probably better to prefer dashes if that's what the majority use already. |
edestecd
force-pushed
the
Feature/15360-UserData_default_should_Patch_the_system_and_reboot
branch
from
b91e003
to
9d9cb7c
Compare
|
Other templates are using the param 'ssh_authorized_keys' and I have seen others with underscore like 'salt_master'. Its a mixed bag at this point. I'm not willing to change them all. Seems like that could break for many that are already using them. |
|
@domcleal I think I fixed everything |
|
Thanks @edestecd! |
edestecd
deleted the
Feature/15360-UserData_default_should_Patch_the_system_and_reboot
branch
No description provided.