Fixes #20814 - Added insmod regexp, removed test

[lzap]

So my previous patch actually did not work, test statement searches for local files and not remote files, therefore the file was never sourced. It looks like source command fail silently, so the test statement is not necessary.

But we found a different thing - some grub2 binaries (namely the one we ship in foreman-bootloaders) do not ship with regexp command compiled in and this must be inserted from a module regexp.mod. The insmod statement does that, otherwise the regexp commandd fails silently. We will need to add modules into foreman-bootloaders.

[lzap]

The insmod fails silently if module is not present, so this won't regress.

[lzap]

@dLobatog watch out when backporting - the if [ -f "$configfile" ]; then was added yesterday but I found it was incorrect. So just ignore that, the only relevant bit here is "insmod regexp"

[dLobatog]

@lzap We don't do backporting with community templates - they are synced on every minor release

[dLobatog]

@lzap Seems reasonable to me, although I haven't tried it, just read some of the BZs associated.

Will we have to do anything when a release of EL7 that fixes the ':' bug?

[dLobatog]

@lzap We don't do backporting with community templates - they are synced on every minor release

[dLobatog]

Thanks @lzap !

[lzap]

Thanks, I can confirm this won't cause any problems, insmod just prints an error if module cannot be found but Grub2 continues execution the next statement.