Skip to content
This repository has been archived by the owner on Jul 9, 2020. It is now read-only.

Fixes #25402 - Update DNF module commands #535

Merged
merged 1 commit into from Nov 12, 2018

Conversation

parthaa
Copy link
Contributor

@parthaa parthaa commented Nov 6, 2018

DNF 4.0 changes the list of module sub commands.
The following commands are no longer valid

  1. Lock
  2. Unlock
  3. Profiles

Also new commands have gotten added

  1. Reset
$ dnf module --help
........
                  {remove,provides,list,update,install,reset,disable,enable,info}
                  [module_spec [module_spec ...]]
......

This commit tries to address those changes.

@theforeman-bot
Copy link
Member

@parthaa, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:

If changing the ticket number used, remember to update the PR title and the commit message (using git commit --amend).


This message was auto-generated by Foreman's prprocessor

@parthaa parthaa changed the title Fixes #25401 - Update DNF module commands Fixes #25402 - Update DNF module commands Nov 6, 2018
DNF 4.0 changes the list of module sub commands.
The following commands are no longer valid
1) Lock
2) Unlock
3) Profiles
Also new commands have gotten added
1) Reset

This commit tries to address those changes.

more
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should keep lock/unlock because on various Fedoras it's still a valid command. YOu also mention reinstall is now a command but I don't see it in the valid options.

@stbenjam
Copy link
Member

stbenjam commented Nov 7, 2018

I don't think I'd still include them - modularity was introduced in Fedora 28, and Fedora 29 introduced DNF 4.x. These options only existed very briefly.

@parthaa
Copy link
Contributor Author

parthaa commented Nov 7, 2018

I wonder if we should keep lock/unlock because on various Fedoras it's still a valid command. YOu also mention reinstall is now a command but I don't see it in the valid options.

I was wrong on reinstall - so removed it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants