Skip to content
This repository has been archived by the owner on Jul 9, 2020. It is now read-only.

Add support to both Legacy and UEFI modes in WIMan templates #726

Closed
wants to merge 1 commit into from
Closed

Add support to both Legacy and UEFI modes in WIMan templates #726

wants to merge 1 commit into from

Conversation

amard33p
Copy link

Please review @ekohl @UXabre

amard33p
amard33p commented Apr 29, 2020
View reviewed changes
provisioning_templates/script/windows_default_script.erb
@@ -61,7 +61,7 @@ echo Writing install image to partition while downloading additional files
start /min cmd /C "echo Downloading finsh script and activating SetupComplete.cmd
md c:\deploy
%WGET% --no-verbose <%= foreman_url("finish") -%> -O C:\deploy\foreman-finish.bat"
) | pause
) | pause >nul
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suppress the 'Press any key to continue' message
foreman_win_fix_script

@amard33p amard33p marked this pull request as ready for review April 29, 2020 09:14
@UXabre
Copy link
Member

UXabre commented Apr 29, 2020

Hi @amard33p,

Thank you for your contribution, looks good to me and looks like an added value as many people requested this so far! Great work! I haven't been able to test this (corona took my lab away); but I trust you did sufficient tests?

Kind regards,
Arend

@ekohl
Copy link
Member

ekohl commented Apr 29, 2020

I don't have any Windows knowledge in this area, but if @UXabre approves the PR I'm happy to merge it.

@amard33p
Copy link
Author

amard33p commented Apr 29, 2020 •
edited

@UXabre Yes I have verified these on both VMs and a Dell PE server.

lzap
lzap approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your words have been put into github records :-)

@tbrisker
Copy link
Member

tbrisker commented Jul 9, 2020

On behalf of the Foreman team, thank you for your contribution to the Foreman community templates repository!
This repository is being archived and all templates are migrated to the relevant repositories. If you wish to pursue this change, please re-open the PR against the relevant repository. For more information and background, please click here.

@tbrisker tbrisker closed this Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lzap lzap lzap approved these changes

Assignees

@lzap lzap

Labels
Needs testing Provisioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@amard33p @UXabre @ekohl @tbrisker @lzap @theforeman-bot