lookup the correct network_id for a given network #1136
Conversation
|
cc @SimonLorentz @fgoebel @cmeissner if y'all want to play around with this. |
|
I tried it against foreman 1.24.3 and 2.1.4 and it works fine with both, thank you very much :D |
|
Thanks @SimonLorentz for testing! I guess you're also on VMware? |
|
Hi @evgeni, yes I tested it against VMware, shell I test it against proxmox or something else? |
|
That would be greatly appreciated, yes. Proxmox is something I don't have easily available here. |
|
Okay I tried it against proxmox, it works, but in proxmox we have as id and name the same value, so that also works without the modification |
|
Okay, updated to error out when the network can't be found. Also made it work on oVirt/RHV. |
|
the devel failures are unrelated and fixed in #1140 |
evgeni
force-pushed
the
issue1104
branch
2 times, most recently
from
85f78bf
to
ab30c1f
Compare
|
okay, maybe that's a bit more complicated for compute_profiles… |
|
|
|
whoa, even better, when listing the networks of a cluster, vmware takes cluster name, ovirt cluster id, what is this… |
|
@SimonLorentz would you mind retesting again in your envs? I did a few changes, which shouldn't affect things that already worked, but you never know. |
|
@m-bucher you might be interested in this too! |
| @@ -41,22 +41,22 @@ ovirt: | |||
| compute_profile: | |||
| name: app-small | |||
| attrs: | |||
| cluster: c95c55f3-705e-4182-92a6-f66754aadf02 | |||
| cluster: Devel-Infra | |||
There was a problem hiding this comment.
there, a working change! :)
| cores: 2 | ||
| sockets: 1 | ||
| memory: 1073741824 | ||
| ha: 0 | ||
| interfaces_attributes: | ||
| 0: | ||
| name: "" | ||
| network: 390666e1-dab3-4c99-9f96-006b2e2fd801 | ||
| network: ovirtmgmt |
There was a problem hiding this comment.
there, a working change too! :)
| interface: virtio | ||
| volumes_attributes: | ||
| 0: | ||
| size_gb: 16 | ||
| storage_domain: 19c50090-1ab4-4023-a63f-75ee1018ed5e | ||
| size_gb: '16' |
There was a problem hiding this comment.
this is "unrelated", but Foreman wants all params to be strings here, whyever.
Fixes: #1104
draft because: