Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source url param to Katello module #163

Closed
wants to merge 1 commit into from
Closed

Add source url param to Katello module #163

wants to merge 1 commit into from

Conversation

chris1984
Copy link
Member

No description provided.

Copy link
Member

@sean797 sean797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you forgotten to commit some changes? All you seem to have done is add a parameter and assign it to a variable?

@chris1984
Copy link
Member Author

@sean797 where else an I supposed to add it?

@evgeni
Copy link
Member

evgeni commented Aug 8, 2018

I think this is missing to pass the new param to the Katello API.

@chris1984
Copy link
Member Author

Closing as this is not needed.

@chris1984 chris1984 closed this Aug 8, 2018
@chris1984 chris1984 reopened this Aug 8, 2018
@chris1984
Copy link
Member Author

This is pending a merge of this:

Katello/katello#7594

Once that gets added I will update this PR.

@sean797
Copy link
Member

sean797 commented Aug 9, 2018

@chris1984 Looking at the Katello PR, I dont think this change depends on it, the source_url param already exists in the Katello API. Also please test this, currently you have documented a new parameter, defined in it the module and then assigned it's to an object, you probably need to pass that object to the Katello API for it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants