Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug #34914 - update remaster script for RHEL8-based 4.0 FDI #150

Closed
wants to merge 1 commit into from

Conversation

pbburke
Copy link

@pbburke pbburke commented Jun 22, 2022

Fixes Bug #34914

@lzap
Copy link
Member

lzap commented Jun 23, 2022

I need to setup an EFI VM to see this, can you explain "But the remaster script still turns the FDI ISO into a flat image with no partition structure.". I don't understand.

The remaster script touches nothing but config files, we actually ship kernel/initramdisk twice on the ISO, we should probably drop one pair to save about 50MB.

@lzap
Copy link
Member

lzap commented Jun 23, 2022

Oh wait the original ISO is created with -cache-inodes option which actually makes a ISO hardlink to the kernel and initramdisk. This explains why remastered ISO is larger by 50MB. I will fix this.

Also I think I know what you mean now, with EL8 (lorax) the EFI ESP is now under /images/ instead of /isolinux where the script expects it. Then it basically fallsback to BIOS only ISO not providing the correct option.

@lzap
Copy link
Member

lzap commented Jun 23, 2022

Ok figured it out all, thanks for the report and the patch. It was more complicated than that. I fixed it in this commit: b94bf01

Please test now. It should be all good now, on top of that the remastered image is now 50MB smaller :)

Cheers.

@lzap lzap closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants