This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
Fixes #9708 - Fixing rubocop config so it can be used with houndci #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
temp/20150310153421
branch
from
baa81cc
to
13ae4ad
Compare
|
apj |
daviddavis
added a commit
that referenced
this pull request
Mar 13, 2015
Fixes #9708 - Fixing rubocop config so it can be used with houndci
|
@daviddavis Please cherry-pick when merging instead of making a merge commit, it can easily make branching for a release quite complicated, and also testing compatibility with previous core versions more difficult. I'll revert this and merge it again, let me know if you have questions or any concerns with the process. |
|
@elobato I know. I just forgot. If you look through our closed PRs, I've been cherrypicking them (aside from this one). In Katello, we merge PRs so chances are I'll probably forget again. Not that I disagree with the process, just it's hard to keep everything straight when working on two different projects with different processes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem in #98