more information about mqtt performance impact considerations & update a file name #2170

Imaanpreet · 2023-04-27T18:09:29Z

I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

Foreman 3.6/Katello 4.8
Foreman 3.5/Katello 4.7 (planned Satellite 6.13)
Foreman 3.4/Katello 4.6 (EL8 only)
Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; planned orcharhino 6.4 on EL8 only)
Foreman 3.2/Katello 4.4 on EL7 & EL8
Foreman 3.1/Katello 4.3 on EL7 & EL8 (Satellite 6.11 EL7/8; orcharhino 6.3 on EL7/8)
For Foreman 3.0 or older, please create a separate PR.
We do not accept PRs for Foreman 2.4 or older.

Imaanpreet · 2023-04-27T18:11:37Z

Hello @adamruzicka : can you please review this PR?

github-actions · 2023-04-27T18:11:54Z

The PR preview for f193841 is available at theforeman-foreman-documentation-preview-pr-2170.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

adamruzicka

Some nitpicks inline, CC @adamlazik1 just in case

guides/common/modules/proc_rex-pull-based-performance-impact-considerations.adoc

Imaanpreet · 2023-04-28T19:40:55Z

@adamruzicka : can we merge this request before Satellite 6.13 GA ?

maximiliankolb

GHA currently fail due to (probably unintended) changes I'd assume. Overall, some text needs to be slightly reworked to align with Foreman documentation.

guides/common/modules/proc_rex-pull-based-performance-impact-considerations.adoc

guides/common/modules/proc_rex-pull-based-transport.adoc

adamruzicka · 2023-05-03T07:14:46Z

@adamruzicka : can we merge this request before Satellite 6.13 GA ?

I cannot merge anything at all here, so we'll see

ekohl · 2023-05-03T10:03:46Z

guides/common/modules/proc_rex-pull-based-transport-tuning.adoc

+
+[options="nowrap", subs="+quotes,verbatim,attributes"]
+----
+cat >/etc/systemd/system/mosquitto.service.d/limits.conf <<__EOF__


I think this one is invalid because the installer will purge this file.

And even if it is, I think we need an issue to track removal of this workaround. eclipse/mosquitto#2674 isn't getting any traction so if this is needed, an installer issue to manage this is needed.

ekohl · 2023-05-03T10:07:44Z

guides/common/modules/proc_rex-pull-based-performance-impact-considerations.adoc

+----
+
+{SmartProxyServer} logs are in `/var/log/foreman-proxy/proxy.log`. 
+{SmartProxyServer} uses Webrick HTTP server (no httpd or Puma involved), so there is no simple way to increase its capacity


If this is a bottleneck, is there an issue opened?

Lennonka

A couple of formal suggestions.

guides/common/modules/proc_rex-pull-based-performance-impact-considerations.adoc

guides/common/modules/proc_rex-pull-based-transport.adoc

guides/common/modules/proc_rex-pull-based-transport-tuning.adoc

guides/common/modules/proc_rex-pull-based-performance-impact-considerations.adoc

guides/common/modules/system-requirements.adoc

guides/doc-Tuning_Performance/master.adoc

ekohl · 2023-08-28T12:55:33Z

Adding the label Waiting on contributor because there are open requests for changes.

Imaanpreet · 2023-08-28T20:49:38Z

Hello, I did the requested changes. Thanks. Please let me know when the entire review is done, will squash all the commits into one.

guides/common/modules/proc_decreasing-performance-impact-of-the-pull-based-rex-transport.adoc

guides/common/modules/proc_rex-pull-based-performance-impact-considerations.adoc

guides/common/modules/proc_rex-pull-based-transport-tuning.adoc

guides/common/modules/proc_rex-pull-based-transport.adoc

ekohl · 2023-09-11T12:49:10Z

@Imaanpreet this is waiting on changes. It also fails to build right now.

Imaanpreet · 2023-09-11T13:30:59Z

I will look at this today, last week I did some changes but there was some conflicts. I will try to resolve this asap. Thank you @ekohl.

guides/common/modules/proc_rex-pull-based-performance-impact-considerations.adoc

guides/common/modules/proc_rex-pull-based-transport-tuning.adoc

mjivraja · 2023-09-25T12:12:09Z

ref_system-requirements-for-tuning.adoc file not found in include. @Imaanpreet

ekohl

Please address @mjivraja's concerns.

Imaanpreet · 2023-10-12T19:48:14Z

hello, I have renamed the file or included the file in this PR.
moreover, I am going to suggest some values for mqtt_rate_limit this week.

Lennonka

@Imaanpreet Thank you! I've unresolved a couple of comments and added a couple more suggestions that need to be addressed.

guides/common/modules/proc_decreasing-performance-impact-of-the-pull-based-rex-transport.adoc

guides/common/modules/proc_tuning-pull-based-rex-transport.adoc

Lennonka · 2023-12-06T12:18:11Z

When those comments will have been addressed, we will probably be ready to merge.

Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>

Imaanpreet · 2023-12-14T18:55:39Z

When those comments will have been addressed, we will probably be ready to merge.

requested changes have been applied. can I squash the commits?

Lennonka

I can squash the commits on merge, so you don't have to worry about that.
However, we are not finished with the content yet, see my comments below, please.

guides/common/modules/proc_tuning-pull-based-rex-transport.adoc

guides/common/modules/proc_increasing-host-limit-for-pull-based-rex-transport.adoc

guides/common/modules/proc_tuning-pull-based-rex-transport.adoc

guides/doc-Tuning_Performance/master.adoc

…d-rex-transport.adoc

…ll-based-rex-transport-tuning.adoc

…port.adoc

Lennonka · 2023-12-18T22:44:48Z

@Imaanpreet I went ahead and finished this off for you. If you need futher updates, please file another PR.

Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>

Lennonka · 2023-12-18T22:47:25Z

Cherry-picked:

333c49a..3bf8cdf 3.9 -> 3.9
77edff9..2a0293f 3.8 -> 3.8
4001a54..52e2d04 3.7 -> 3.7
fa93011..7360e83 3.6 -> 3.6
c40c98b..e79c18e 3.5 -> 3.5
778d34f..d685a76 3.4 -> 3.4
9768bdd..0bd3310 3.3 -> 3.3

Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>

Imaanpreet mentioned this pull request Apr 27, 2023

change the file name from Performance_Tuning_System_Requirements to System_Requirements #2168

Closed

7 tasks

adamruzicka reviewed Apr 28, 2023

View reviewed changes

Imaanpreet force-pushed the mqtt branch from 624d1d5 to 04d37c3 Compare April 28, 2023 19:38

maximiliankolb requested changes May 2, 2023

View reviewed changes

ekohl reviewed May 3, 2023

View reviewed changes

Lennonka requested changes Jul 6, 2023

View reviewed changes

ekohl added the Waiting on contributor Requires an action from the author label Aug 28, 2023

maximiliankolb requested changes Aug 29, 2023

View reviewed changes

mjivraja reviewed Sep 13, 2023

View reviewed changes

guides/common/modules/proc_rex-pull-based-performance-impact-considerations.adoc Outdated Show resolved Hide resolved

mjivraja reviewed Sep 13, 2023

View reviewed changes

guides/common/modules/proc_rex-pull-based-performance-impact-considerations.adoc Outdated Show resolved Hide resolved

mjivraja reviewed Sep 13, 2023

View reviewed changes

guides/common/modules/proc_rex-pull-based-performance-impact-considerations.adoc Outdated Show resolved Hide resolved

mjivraja reviewed Sep 13, 2023

View reviewed changes

guides/common/modules/proc_rex-pull-based-performance-impact-considerations.adoc Outdated Show resolved Hide resolved

mjivraja reviewed Sep 13, 2023

View reviewed changes

guides/common/modules/proc_rex-pull-based-transport-tuning.adoc Outdated Show resolved Hide resolved

pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Sep 21, 2023

ekohl requested changes Oct 12, 2023

View reviewed changes

pr-processor bot added Waiting on contributor Requires an action from the author Needs re-review and removed Needs re-review Waiting on contributor Requires an action from the author labels Oct 12, 2023

Lennonka requested changes Dec 6, 2023

View reviewed changes

pr-processor bot added Waiting on contributor Requires an action from the author and removed Needs re-review labels Dec 6, 2023

Apply suggestions from code review

3a5616f

Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>

pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Dec 14, 2023

Lennonka requested changes Dec 14, 2023

View reviewed changes

pr-processor bot added Waiting on contributor Requires an action from the author and removed Needs re-review labels Dec 14, 2023

Update guides/common/modules/proc_increasing-host-limit-for-pull-base…

f34b179

…d-rex-transport.adoc

pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Dec 18, 2023

Lennonka added 4 commits December 18, 2023 23:17

Update proc_increasing-host-limit-for-pull-based-rex-transport.adoc

598a87a

Update and rename proc_tuning-pull-based-rex-transport.adoc to con_pu…

5a6dab9

…ll-based-rex-transport-tuning.adoc

Update guides/doc-Tuning_Performance/master.adoc

1982b4d

Update proc_decreasing-performance-impact-of-the-pull-based-rex-trans…

f193841

…port.adoc

Lennonka merged commit 8dc3c9f into theforeman:master Dec 18, 2023
8 checks passed

Lennonka added a commit that referenced this pull request Dec 18, 2023

Add mqtt performance tuning (#2170)

3bf8cdf

Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>

Lennonka added a commit that referenced this pull request Dec 18, 2023

Add mqtt performance tuning (#2170)

2a0293f

Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>

Lennonka added a commit that referenced this pull request Dec 18, 2023

Add mqtt performance tuning (#2170)

52e2d04

Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>

Lennonka added a commit that referenced this pull request Dec 18, 2023

Add mqtt performance tuning (#2170)

7360e83

Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>

Lennonka added a commit that referenced this pull request Dec 18, 2023

Add mqtt performance tuning (#2170)

e79c18e

Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>

Lennonka added a commit that referenced this pull request Dec 18, 2023

Add mqtt performance tuning (#2170)

d685a76

Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>

Lennonka added a commit that referenced this pull request Dec 18, 2023

Add mqtt performance tuning (#2170)

0bd3310

Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>

ianballou pushed a commit to ianballou/foreman-documentation that referenced this pull request Dec 19, 2023

Add mqtt performance tuning (theforeman#2170)

2827e9b

Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>

ianballou pushed a commit that referenced this pull request Dec 20, 2023

Add mqtt performance tuning (#2170)

3436e19

Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

more information about mqtt performance impact considerations & update a file name #2170

more information about mqtt performance impact considerations & update a file name #2170

Imaanpreet commented Apr 27, 2023 •

edited

Imaanpreet commented Apr 27, 2023 •

edited

github-actions bot commented Apr 27, 2023 •

edited

adamruzicka left a comment

Imaanpreet commented Apr 28, 2023

maximiliankolb left a comment

adamruzicka commented May 3, 2023

ekohl May 3, 2023

ekohl May 3, 2023

Lennonka left a comment

ekohl commented Aug 28, 2023

Imaanpreet commented Aug 28, 2023

ekohl commented Sep 11, 2023

Imaanpreet commented Sep 11, 2023

mjivraja commented Sep 25, 2023

ekohl left a comment

Imaanpreet commented Oct 12, 2023

Lennonka left a comment

Lennonka commented Dec 6, 2023

Imaanpreet commented Dec 14, 2023 •

edited

Lennonka left a comment

Lennonka commented Dec 18, 2023 •

edited

Lennonka commented Dec 18, 2023

more information about mqtt performance impact considerations & update a file name #2170

more information about mqtt performance impact considerations & update a file name #2170

Conversation

Imaanpreet commented Apr 27, 2023 • edited

Imaanpreet commented Apr 27, 2023 • edited

github-actions bot commented Apr 27, 2023 • edited

adamruzicka left a comment

Choose a reason for hiding this comment

Imaanpreet commented Apr 28, 2023

maximiliankolb left a comment

Choose a reason for hiding this comment

adamruzicka commented May 3, 2023

ekohl May 3, 2023

Choose a reason for hiding this comment

ekohl May 3, 2023

Choose a reason for hiding this comment

Lennonka left a comment

Choose a reason for hiding this comment

ekohl commented Aug 28, 2023

Imaanpreet commented Aug 28, 2023

ekohl commented Sep 11, 2023

Imaanpreet commented Sep 11, 2023

mjivraja commented Sep 25, 2023

ekohl left a comment

Choose a reason for hiding this comment

Imaanpreet commented Oct 12, 2023

Lennonka left a comment

Choose a reason for hiding this comment

Lennonka commented Dec 6, 2023

Imaanpreet commented Dec 14, 2023 • edited

Lennonka left a comment

Choose a reason for hiding this comment

Lennonka commented Dec 18, 2023 • edited

Lennonka commented Dec 18, 2023

Imaanpreet commented Apr 27, 2023 •

edited

Imaanpreet commented Apr 27, 2023 •

edited

github-actions bot commented Apr 27, 2023 •

edited

Imaanpreet commented Dec 14, 2023 •

edited

Lennonka commented Dec 18, 2023 •

edited