Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] Hide guides which aren't ready for consumption #2334

Merged
merged 1 commit into from
Aug 31, 2023
Merged

[3.7] Hide guides which aren't ready for consumption #2334

merged 1 commit into from
Aug 31, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Aug 3, 2023

Some guides aren't usable in some flavors. They aren't linked in the navigation, but this also makes sure the files don't have any content. That makes diffs smaller, which makes reviewing easier.

(cherry picked from commit f5790e0)

This is just as a PR to see the diff of #2321 for now.

@ekohl ekohl mentioned this pull request Aug 3, 2023
Merged
@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited

The PR preview for 697f8c5 is available at theforeman-foreman-documentation-preview-pr-2334.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@ekohl ekohl force-pushed the 3.7-hide-not-ready-guides branch from 20a9d7b to 7422e21 Compare August 3, 2023 13:38
@ekohl
Copy link
Member Author

ekohl commented Aug 3, 2023

Somehow the link checker is broken for something, and I can reproduce it on my browser.

Check time 5.177 seconds
Size       259B
Info       Redirected to
           `https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html-single/installing_identity_management/index#port-requirements-for-idm_preparing-the-system-for-ipa-server-installation'.
Result     Error: TooManyRedirects: Exceeded 10 redirects.

@ekohl ekohl force-pushed the 3.7-hide-not-ready-guides branch 2 times, most recently from b5df79a to f5852e8 Compare August 10, 2023 10:10
@ekohl ekohl marked this pull request as ready for review August 10, 2023 10:10
@ekohl
Copy link
Member Author

ekohl commented Aug 10, 2023

I've just picked the merged commit from master and this should be the final version of this PR.

@ekohl ekohl changed the title Hide guides which aren't ready for consumption [3.7] Hide guides which aren't ready for consumption Aug 10, 2023
@ekohl
Hide guides which aren't ready for consumption
697f8c5 
Some guides aren't usable in some flavors. They aren't linked in the
navigation, but this also makes sure the files don't have any content.
That makes diffs smaller, which makes reviewing easier.

(cherry picked from commit 724dc9c)
@ekohl ekohl mentioned this pull request Aug 31, 2023
Merged
8 tasks
@ekohl ekohl merged commit 09a8c51 into theforeman:3.7 Aug 31, 2023
9 checks passed
@ekohl ekohl deleted the 3.7-hide-not-ready-guides branch August 31, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ekohl