Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #36573 - Remove --puppet-server-foreman-url parameter #2432

Merged
merged 1 commit into from Sep 25, 2023
Merged

Refs #36573 - Remove --puppet-server-foreman-url parameter #2432

merged 1 commit into from Sep 25, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 14, 2023

Since Foreman 3.8 the --foreman-proxy-foreman-base-url parameter is reused.

Please cherry-pick my commits into:

  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (planned Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • Foreman 3.2/Katello 4.4 on EL7 & EL8
  • Foreman 3.1/Katello 4.3 on EL7 & EL8 (Satellite 6.11 EL7/8; orcharhino 6.3 on EL7/8)
  • We do not accept PRs for Foreman older than 3.1.

@ekohl
Refs #36573 - Remove --puppet-server-foreman-url parameter
63619c0 
Since Foreman 3.8 the --foreman-proxy-foreman-base-url parameter is
reused.
@github-actions
Copy link

The PR preview for 63619c0 is available at theforeman-foreman-documentation-preview-pr-2432.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

This was referenced Sep 14, 2023
Merged
Merged
maximiliankolb
maximiliankolb approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself looks good to me. How can ACK this? Is there a commit/ticket that shows this change?

@ekohl
Copy link
Member Author

ekohl commented Sep 18, 2023

Change itself looks good to me. How can ACK this? Is there a commit/ticket that shows this change?

I reference it in the title. If you go to Checks -> PR Processor -> Redmine issues (https://github.com/theforeman/foreman-documentation/pull/2432/checks?check_run_id=16788620612 right now) you can see the Redmine link. I admit this is well hidden and wish there was a better way (other than posting a comment).

@maximiliankolb
Copy link
Contributor

Change itself looks good to me. How can ACK this? Is there a commit/ticket that shows this change?

I reference it in the title. If you go to Checks -> PR Processor -> Redmine issues (https://github.com/theforeman/foreman-documentation/pull/2432/checks?check_run_id=16788620612 right now) you can see the Redmine link. I admit this is well hidden and wish there was a better way (other than posting a comment).

Fixed in Releases: Foreman - 3.8.0 > so I'd say "merge" 👍

@ekohl ekohl mentioned this pull request Sep 20, 2023
Merged
9 tasks
@maximiliankolb maximiliankolb merged commit bf7b9be into theforeman:master Sep 25, 2023
9 checks passed
maximiliankolb pushed a commit that referenced this pull request Sep 25, 2023
@ekohl @maximiliankolb
Refs #36573 - Remove --puppet-server-foreman-url parameter (#2432)
37a6718 
Since Foreman 3.8 the --foreman-proxy-foreman-base-url parameter is
reused.

(cherry picked from commit bf7b9be)
@maximiliankolb
Copy link
Contributor

Merged to master and cherry-picked to 3.8: ✔️
531c87f..37a6718 3.8 -> 3.8

@ekohl ekohl deleted the 36573-remove-puppet-server-foreman-url branch October 3, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankolb maximiliankolb maximiliankolb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ekohl @maximiliankolb