Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete list of FDI kernel options #2464

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

maximiliankolb
Copy link
Contributor

@maximiliankolb maximiliankolb commented Sep 25, 2023

Squash before merging!

Please cherry-pick my commits into:

  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (planned Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13)

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the list sorted?

@ekohl ekohl linked an issue Sep 25, 2023 that may be closed by this pull request
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now with a review.

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Sep 25, 2023
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Sep 26, 2023
@maximiliankolb
Copy link
Contributor Author

I have sorted the list but did not find any comments @ekohl

@ekohl
Copy link
Member

ekohl commented Sep 26, 2023

did not find any comments

I wanted to show the PR prprocessor doing its thing with the labels.

@ekohl ekohl changed the title Resolves #44 Complete list of FDI kernel options Sep 26, 2023
@ekohl ekohl added the Needs style review Requires a review from docs style/grammar perspective label Sep 26, 2023
@ekohl
Copy link
Member

ekohl commented Sep 26, 2023

Any writer would like to review the style?

@maximiliankolb maximiliankolb merged commit 61a83ab into theforeman:master Sep 26, 2023
8 checks passed
@maximiliankolb maximiliankolb deleted the resolves_44 branch September 26, 2023 15:14
maximiliankolb added a commit that referenced this pull request Sep 26, 2023
* Add list of FDI parameters
* Remove leading whitespace
* Sort items in alphabetical order

https://theforeman.org/plugins/foreman_discovery/18.0/index.html#3.1.5Discoveryimagekerneloptions
(cherry picked from commit 61a83ab)
maximiliankolb added a commit that referenced this pull request Sep 26, 2023
* Add list of FDI parameters
* Remove leading whitespace
* Sort items in alphabetical order

https://theforeman.org/plugins/foreman_discovery/18.0/index.html#3.1.5Discoveryimagekerneloptions
(cherry picked from commit 61a83ab)
maximiliankolb added a commit that referenced this pull request Sep 26, 2023
* Add list of FDI parameters
* Remove leading whitespace
* Sort items in alphabetical order

https://theforeman.org/plugins/foreman_discovery/18.0/index.html#3.1.5Discoveryimagekerneloptions
(cherry picked from commit 61a83ab)
maximiliankolb added a commit that referenced this pull request Sep 26, 2023
* Add list of FDI parameters
* Remove leading whitespace
* Sort items in alphabetical order

https://theforeman.org/plugins/foreman_discovery/18.0/index.html#3.1.5Discoveryimagekerneloptions
(cherry picked from commit 61a83ab)
@maximiliankolb
Copy link
Contributor Author

Merged to master and cherry-picked: ✔️
f25105d..880b1de 3.8 -> 3.8
d9fd7c2..7195adf 3.7 -> 3.7
dd6945b..b882e02 3.6 -> 3.6
6d49ee8..79d31fb 3.5 -> 3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs style review Requires a review from docs style/grammar perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate 3.1.5 Discovery image kernel options
3 participants