Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release notes for Katello 4.9.2 #2479

Merged
merged 1 commit into from Oct 4, 2023
Merged

Update release notes for Katello 4.9.2 #2479

merged 1 commit into from Oct 4, 2023

Conversation

wbclark
Copy link
Contributor

@wbclark wbclark commented Sep 28, 2023

Also includes release notes for Katello 4.9.1

Please cherry-pick my commits into:

  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (planned Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • Foreman 3.2/Katello 4.4 on EL7 & EL8
  • Foreman 3.1/Katello 4.3 on EL7 & EL8 (Satellite 6.11 EL7/8; orcharhino 6.3 on EL7/8)
  • We do not accept PRs for Foreman older than 3.1.

@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited

The PR preview for df34b9e is available at theforeman-foreman-documentation-preview-pr-2479.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@wbclark wbclark force-pushed the katello-4.9.2 branch 2 times, most recently from 0e067d1 to 9abf40c Compare September 28, 2023 18:31
@ianballou
Copy link
Contributor

I think this pull request in general only needs to go against the Foreman 3.7 branch. The file where you added forman 3.7.0 and katello 4.9.0 versions should already have those on the 3.7 branch

ekohl
ekohl requested changes Sep 29, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @ianballou said, this should be against the Foreman branch.

We should enhance the procedure instructions to be explicit about that.

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Sep 29, 2023
@wbclark wbclark changed the base branch from master to 3.7 September 29, 2023 15:19
@wbclark
Copy link
Contributor Author

wbclark commented Sep 29, 2023

I changed the base branch of the PR but it looks like I'll need to rebase and force push as well

@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Sep 29, 2023
wbclark
wbclark commented Sep 29, 2023
View reviewed changes
guides/doc-Release_Notes/topics/katello-4.9.0.adoc
@@ -85,7 +85,6 @@ A full list of changes is available on https://projects.theforeman.org/issues?se

=== Repositories

* Can\'t remove GPG and SSL Keys from existing Product using the API - https://projects.theforeman.org/issues/36497[#36497]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't included in 4.9.0 but is now included in katello 4.9.2

ianballou
ianballou approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me!

@ianballou ianballou requested a review from ekohl October 2, 2023 15:27
ekohl
ekohl requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor notes, but overall this looks good.

guides/doc-Release_Notes/master.adoc Outdated
@@ -14,7 +14,11 @@ endif::[]

// Start inserting specific x.y.z releases here
include::topics/foreman-3.7.0.adoc[leveloffset=+1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd list Foreman last. Foreman 3.7.0 was released before Katello 4.9.0.

My reasoning is that you remember I updated to X.Y.Z last, so I read till there. That probably needs to written down somewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look at updating the instructions from the procedure. Thanks!

guides/doc-Release_Notes/topics/katello-contributors.adoc Outdated Show resolved Hide resolved
@pr-processor pr-processor bot added the Waiting on contributor Requires an action from the author label Oct 2, 2023
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Oct 2, 2023
ekohl
ekohl reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for the preview to render, but from reading the source this looks correct.

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Needs re-review labels Oct 3, 2023
@ekohl ekohl mentioned this pull request Oct 3, 2023
Merged
9 tasks
@pr-processor pr-processor bot removed the Waiting on contributor Requires an action from the author label Oct 4, 2023
@wbclark
Copy link
Contributor Author

wbclark commented Oct 4, 2023

@ekohl I left it as a separate commit for ease of review, with the intent to squash before merging

wbclark
wbclark commented Oct 4, 2023
View reviewed changes
guides/doc-Release_Notes/topics/katello-4.9.0.adoc
@@ -71,7 +71,7 @@ A full list of changes is available on https://projects.theforeman.org/issues?se
* Package upgradable versions are not set correctly based on architecture - https://projects.theforeman.org/issues/36100[#36100]
* Host cloning is broken - https://projects.theforeman.org/issues/36064[#36064]
* Setting a Content Source is not persistent - https://projects.theforeman.org/issues/35834[#35834]
* \'System purpose\' modal doesn\'t reset after switching hosts with switcher - https://projects.theforeman.org/issues/35324[#35324]
* 'System purpose' modal doesn\'t reset after switching hosts with switcher - https://projects.theforeman.org/issues/35324[#35324]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn\'t was rendered as doesn't in the page last time, so I left it alone

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you understand why my script generated wrong escaping: asciidoc escaping is hard.

wbclark
wbclark commented Oct 4, 2023
View reviewed changes
guides/doc-Release_Notes/topics/katello-contributors.adoc
Sayan Das
Stephan Bergmann
Trevor Allison
Adam Růžička,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commas added to match the formatting of foreman-contributors

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I like this. It's much easier to maintain than a huge sentence and I didn't think of this. We should standardize on this.

ekohl
ekohl approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let me know when it's ready to merge.

@wbclark
Update release notes for Katello 4.9.2
df34b9e 
Also includes release notes for Katello 4.9.1
@wbclark
Copy link
Contributor Author

wbclark commented Oct 4, 2023

Thanks @ekohl , it's squashed and ready for merge

@ianballou
Copy link
Contributor

Merging since Katello 4.9.2 is built

@ianballou ianballou merged commit 44f1fee into theforeman:3.7 Oct 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@ianballou ianballou ianballou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wbclark @ianballou @ekohl