New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for Katello 4.10.0 - Release notes #2481
Conversation
27bbdfb
to
47ebfc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've kicked off GHA, so a preview should render soon. You can also create this locally, see the README files.
3b4beba
to
0d3b8cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't include a period in headers. Your headers are also very long. If you look in the table of contents it will be very cramped. That's why we include the long version in the body of the chapter.
87d10a7
to
d807970
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, will let @ekohl merge since I don't have merge perms.
@damoore044 when I fix up these, I always go to Redmine and fix the issues there. Then I regenerate the file. |
1470895
to
df85bf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more to remain consistent and we are GTG. You can directly apply changes from here.
df85bf8
to
184d324
Compare
@mjivraja do you know what might be causing that strange failure? Is it a known one on the main branch? |
Yes, it's fixed in eb7655b |
a8c2141
to
d3a7aae
Compare
d3a7aae
to
7a8a316
Compare
fix small commit issue foreman-3.8 Addressing comments
7a8a316
to
4c3d9f1
Compare
The rendered preview is a bit bigger because the PR isn't quite up to date anymore. I'm going to merge this now and any further changes can be made in follow up PRs. |
Please cherry-pick my commits into: