Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Katello 4.10.0 - Release notes #2481

Merged
merged 3 commits into from Oct 26, 2023

Conversation

damoore044
Copy link

@damoore044 damoore044 commented Sep 29, 2023

Please cherry-pick my commits into:

  • Foreman 3.8/Katello 4.10

guides/doc-Release_Notes/topics/katello-4.10.0.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello-contributors.adoc Outdated Show resolved Hide resolved
@damoore044 damoore044 changed the title Updates for Katello 4.10.0.rc2 - Release notes Updates for Katello 4.10.0 - Release notes Sep 29, 2023
guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Sep 29, 2023
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've kicked off GHA, so a preview should render soon. You can also create this locally, see the README files.

guides/doc-Release_Notes/topics/katello-contributors.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello-contributors.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Sep 29, 2023
guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author Needs re-review and removed Needs re-review Waiting on contributor Requires an action from the author labels Sep 29, 2023
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't include a period in headers. Your headers are also very long. If you look in the table of contents it will be very cramped. That's why we include the long version in the body of the chapter.

guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author Needs re-review and removed Needs re-review Waiting on contributor Requires an action from the author labels Sep 29, 2023
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will let @ekohl merge since I don't have merge perms.

@pr-processor pr-processor bot added the Waiting on contributor Requires an action from the author label Oct 6, 2023
@ekohl
Copy link
Member

ekohl commented Oct 6, 2023

@damoore044 when I fix up these, I always go to Redmine and fix the issues there. Then I regenerate the file.

@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Oct 6, 2023
Copy link
Contributor

@mjivraja mjivraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more to remain consistent and we are GTG. You can directly apply changes from here.

guides/doc-Release_Notes/topics/katello-4.10.0.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello-4.10.0.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello-4.10.0.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello-4.10.0.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello-4.10.0.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello-4.10.0.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello-4.10.0.adoc Outdated Show resolved Hide resolved
guides/doc-Release_Notes/topics/katello-4.10.0.adoc Outdated Show resolved Hide resolved
@ianballou
Copy link
Contributor

@mjivraja do you know what might be causing that strange failure? Is it a known one on the main branch?

@evgeni
Copy link
Member

evgeni commented Oct 13, 2023

Yes, it's fixed in eb7655b
Just rebase on latest 3.8 branch ;)

@damoore044 damoore044 force-pushed the 4.10.0rc2-doc-updates branch 2 times, most recently from a8c2141 to d3a7aae Compare October 18, 2023 15:02
@pr-processor pr-processor bot added the Waiting on contributor Requires an action from the author label Oct 19, 2023
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Oct 20, 2023
@ekohl ekohl added Waiting on contributor Requires an action from the author and removed Needs re-review labels Oct 24, 2023
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Oct 24, 2023
@ekohl
Copy link
Member

ekohl commented Oct 26, 2023

The rendered preview is a bit bigger because the PR isn't quite up to date anymore. I'm going to merge this now and any further changes can be made in follow up PRs.

@ekohl ekohl merged commit 4f890f4 into theforeman:3.8 Oct 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants