New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release notes for Foreman 3.8 GA #2504
Conversation
The PR preview for f2b19d5 is available at theforeman-foreman-documentation-preview-pr-2504.surge.sh The following output files are affected by this PR: |
|
||
=== API | ||
|
||
* GraphQL: Incorrect totalCount when querying with first parameter - https://projects.theforeman.org/issues/36509[#36509] | ||
* Unable to access API using non-admin users. - https://projects.theforeman.org/issues/36449[#36449] | ||
* pass:[GraphQL: Incorrect totalCount when querying with first parameter] - https://projects.theforeman.org/issues/36509[#36509] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is pass:[...]
for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I picked it, so if you rebase it I expect it to pass. I still want to add a headline feature before we announce it, but that can be done in a separate PR. |
That's to describe theforeman/foreman-installer#878. |
791f80f
to
b15dacc
Compare
Looks like RHEL docs changed something:
Not related to this change. However, it does break the preview rendering. #2506 is intended to fix that, but wasn't picked yet. |
Another pick I did, so again: please rebase. |
b15dacc
to
7afe76f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now see We’d like to thank the following people who contributed to the Foreman {{page.version}} release:
in the contributors section. That's a direct copy from our other repo. Here you need to use {ProjectVersion}
as the macro.
Other than that I think this is ready.
Nice catch! Updating now |
7afe76f
to
f2b19d5
Compare
It's why I wanted it to generate a preview, really makes reviewing easier :) |
Please cherry-pick my commits into: