Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release notes for Foreman 3.8 GA #2504

Merged
merged 1 commit into from Oct 12, 2023

Conversation

Griffin-Sullivan
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan commented Oct 10, 2023

Please cherry-pick my commits into:

  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (planned Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • Foreman 3.2/Katello 4.4 on EL7 & EL8
  • Foreman 3.1/Katello 4.3 on EL7 & EL8 (Satellite 6.11 EL7/8; orcharhino 6.3 on EL7/8)
  • We do not accept PRs for Foreman older than 3.1.


=== API

* GraphQL: Incorrect totalCount when querying with first parameter - https://projects.theforeman.org/issues/36509[#36509]
* Unable to access API using non-admin users. - https://projects.theforeman.org/issues/36449[#36449]
* pass:[GraphQL: Incorrect totalCount when querying with first parameter] - https://projects.theforeman.org/issues/36509[#36509]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is pass:[...] for?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl
Copy link
Member

ekohl commented Oct 11, 2023

Looks like we cherry picked #2427 but not #2437.

@ekohl
Copy link
Member

ekohl commented Oct 11, 2023

I picked it, so if you rebase it I expect it to pass. I still want to add a headline feature before we announce it, but that can be done in a separate PR.

@ekohl
Copy link
Member

ekohl commented Oct 11, 2023

I still want to add a headline feature before we announce it, but that can be done in a separate PR.

That's to describe theforeman/foreman-installer#878.

@ekohl
Copy link
Member

ekohl commented Oct 11, 2023

Looks like RHEL docs changed something:

URL        `https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/configuring_basic_system_settings/using-chrony-to-configure-ntp_configuring-basic-system-settings'
Name       `Using the Chrony suite to configure NTP'
Parent URL file:///home/runner/work/foreman-documentation/foreman-documentation/guides/build/Installing_Server/index-katello.html, line 1377, col 66
Real URL   https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/configuring_basic_system_settings/using-chrony-to-configure-ntp_configuring-basic-system-settings
Check time 6.295 seconds
Size       9KB
Result     Error: 404 Not Found

Not related to this change. However, it does break the preview rendering. #2506 is intended to fix that, but wasn't picked yet.

@ekohl
Copy link
Member

ekohl commented Oct 11, 2023

Another pick I did, so again: please rebase.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now see We’d like to thank the following people who contributed to the Foreman {{page.version}} release: in the contributors section. That's a direct copy from our other repo. Here you need to use {ProjectVersion} as the macro.

Other than that I think this is ready.

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Oct 12, 2023
@Griffin-Sullivan
Copy link
Contributor Author

Nice catch! Updating now

@ekohl
Copy link
Member

ekohl commented Oct 12, 2023

It's why I wanted it to generate a preview, really makes reviewing easier :)

@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Oct 12, 2023
@ekohl ekohl merged commit 31aad3d into theforeman:3.8 Oct 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants