Re-modularize the Monitoring Hosts section #2555

mjivraja · 2023-10-25T15:17:25Z

Re-modularize the Monitoring Hosts section in the Managing Hosts guide. This was decided in the #2502.

I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

Foreman 3.8/Katello 4.10
Foreman 3.7/Katello 4.9 (planned Satellite 6.14)
Foreman 3.6/Katello 4.8
Foreman 3.5/Katello 4.7 (Satellite 6.13)
Foreman 3.4/Katello 4.6 (EL8 only)
Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
Foreman 3.2/Katello 4.4 on EL7 & EL8
Foreman 3.1/Katello 4.3 on EL7 & EL8 (Satellite 6.11 EL7/8; orcharhino 6.3 on EL7/8)
We do not accept PRs for Foreman older than 3.1.

github-actions · 2023-10-25T15:25:05Z

The PR preview for c46b238 is available at theforeman-foreman-documentation-preview-pr-2555.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

Lennonka

Generally, I think we can say just "Insights" instead of "Red Hat Insights" after the first fully-spelled occurence in the chapter title.
I'm suggesting a couple of initial thoughts on the module titles. (This includes also changing the file names and IDs.)
I will continue my review once these are agreed upon and incorporated.

guides/common/modules/proc_using-red-hat-insights.adoc

.../modules/proc_remove-hosts-from-red-hat-insights-inventory-and-satellite-simultaneously.adoc

guides/common/modules/proc_synchronize-red-hat-insights-recommendations-for-hosts.adoc

guides/common/modules/ref_accessing-information-of-hosts-through-red-hat-insights.adoc

mjivraja · 2023-11-02T07:35:16Z

Oww no, why does the old guide Upgrading and Updating appear again in 6.14? 😲

Lennonka

Please, try again. I'd like to move on to the really important stuff.

You did a good job with the remodularization, initially! I just thought we could take this opportunity to review and improve it in more detail.

guides/common/assembly_monitoring-hosts-using-red-hat-insights.adoc

guides/common/modules/con_monitoring_hosts_using-red-hat-insights.adoc

mjivraja · 2023-11-03T13:26:59Z

Apologies @Lennonka I overlooked things due to last-minute GA priorities. 😕

mjivraja · 2023-11-03T13:28:43Z

This time, the picture seems to be much bigger in linkchecker 😲

Lennonka · 2023-11-03T15:52:59Z

This time, the picture seems to be much bigger in linkchecker 😲

@mjivraja After re-running the linkchecker, the RHEL links are now alright. Please, rebase.

mjivraja · 2023-11-06T06:01:21Z

@mjivraja After re-running the linkchecker, the RHEL links are now alright. Please, rebase.

Addressed 👍

Lennonka

Another piece of review.

guides/common/modules/con_monitoring-hosts-using-red-hat-insights.adoc

.../common/modules/proc_configuring-automatic-removal-of-hosts-from-the-insights-inventory.adoc

...odules/proc_configuring-automatic-synchronization-of-insights-recommendations-for-hosts.adoc

guides/common/assembly_monitoring-hosts-using-red-hat-insights.adoc

.../common/modules/proc_configuring-automatic-removal-of-hosts-from-the-insights-inventory.adoc

mjivraja · 2023-11-20T11:44:04Z

Working on linkchecker

mjivraja · 2023-11-20T12:45:19Z

Working on linkchecker

Will get fixed here #2596

...odules/proc_configuring-automatic-synchronization-of-insights-recommendations-for-hosts.adoc

guides/common/modules/ref_access-to-information-from-insights-in-project.adoc

maximiliankolb

Please rebase to master and resolve the merge conflict.

ShimShtein · 2023-12-07T14:54:18Z

LGTM from my side.

Lennonka · 2023-12-07T16:07:08Z

Cherry-picked:

cf8a3cb..51f77f5 3.9 -> 3.9
7e66ebe..f619884 3.8 -> 3.8

@mjivraja Conflicts on 3.7. Please file a separate PR.

FYI, please also prepare a separate PR for 3.6, because the hosts removal sync module isn't supposed to be there before 3.7 (#2502). Whether the rest of the modules is applicable to older branches is also questionable, please double check that with the current published docs.

Lennonka · 2023-12-07T16:08:30Z

@mjivraja On the other hand, do we necessarily have to cherry-pick this to 3.6 and older? For your consideration.
It would be nice to have, but it's additional work as mentioned above.

mjivraja · 2023-12-08T06:26:45Z

@mjivraja Conflicts on 3.7. Please file a separate PR.

FYI, please also prepare a separate PR for 3.6, because the hosts removal sync module isn't supposed to be there before 3.7 (#2502). Whether the rest of the modules is applicable to older branches is also questionable, please double check that with the current published docs.

Thanks for heads-up, @Lennonka

I completely overlooked the #2502 and I agree that this PR should not be cherry-picked below 3.7.

Here we go for 3.7: #2634

pr-processor bot added the Not yet reviewed label Oct 25, 2023

mjivraja requested a review from Lennonka October 25, 2023 15:23

Lennonka requested changes Oct 30, 2023

View reviewed changes

pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Oct 30, 2023

mjivraja force-pushed the Remodularize-Insights-with-Hosts-sections-master branch from 4591cfb to 459226b Compare November 2, 2023 07:23

pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Nov 2, 2023

mjivraja force-pushed the Remodularize-Insights-with-Hosts-sections-master branch from 459226b to 87158a9 Compare November 2, 2023 07:27

Lennonka requested changes Nov 2, 2023

View reviewed changes

pr-processor bot added Waiting on contributor Requires an action from the author and removed Needs re-review labels Nov 2, 2023

mjivraja force-pushed the Remodularize-Insights-with-Hosts-sections-master branch from 87158a9 to 15f62e3 Compare November 3, 2023 13:21

pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Nov 3, 2023

mjivraja force-pushed the Remodularize-Insights-with-Hosts-sections-master branch from 15f62e3 to eda8f73 Compare November 6, 2023 05:53

Lennonka requested changes Nov 7, 2023

View reviewed changes

pr-processor bot added Waiting on contributor Requires an action from the author and removed Needs re-review labels Nov 7, 2023

mjivraja force-pushed the Remodularize-Insights-with-Hosts-sections-master branch from eda8f73 to 88425cb Compare November 20, 2023 11:30

pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Nov 20, 2023

pr-processor bot added the Waiting on contributor Requires an action from the author label Nov 21, 2023

mjivraja force-pushed the Remodularize-Insights-with-Hosts-sections-master branch from c19376c to 951d497 Compare November 28, 2023 13:54

pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Nov 28, 2023

Lennonka requested changes Nov 28, 2023

View reviewed changes

pr-processor bot added Waiting on contributor Requires an action from the author and removed Needs re-review labels Nov 28, 2023

mjivraja force-pushed the Remodularize-Insights-with-Hosts-sections-master branch from 951d497 to 356f7c2 Compare November 29, 2023 05:46

pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Nov 29, 2023

mjivraja force-pushed the Remodularize-Insights-with-Hosts-sections-master branch from 356f7c2 to 42fe542 Compare November 29, 2023 10:51

maximiliankolb reviewed Dec 6, 2023

View reviewed changes

mjivraja added 2 commits December 7, 2023 19:35

Re-modularize the Monitoring Hosts section

dfdf14b

Lena and Shim's suggestion

c46b238

mjivraja force-pushed the Remodularize-Insights-with-Hosts-sections-master branch from 42fe542 to c46b238 Compare December 7, 2023 14:10

Lennonka approved these changes Dec 7, 2023

View reviewed changes

pr-processor bot removed the Needs re-review label Dec 7, 2023

Lennonka merged commit ca90dcf into theforeman:master Dec 7, 2023
8 checks passed

Lennonka pushed a commit that referenced this pull request Dec 7, 2023

Re-modularize the Monitoring Hosts section (#2555)

51f77f5

Lennonka pushed a commit that referenced this pull request Dec 7, 2023

Re-modularize the Monitoring Hosts section (#2555)

f619884

mjivraja deleted the Remodularize-Insights-with-Hosts-sections-master branch December 8, 2023 06:14

mjivraja added a commit to mjivraja/foreman-documentation that referenced this pull request Dec 8, 2023

Re-modularize the Monitoring Hosts section (theforeman#2555)

7e12a63

mjivraja mentioned this pull request Dec 8, 2023

Re-modularize the Monitoring Hosts section 3.7 #2634

Merged

Lennonka pushed a commit that referenced this pull request Dec 11, 2023

Re-modularize the Monitoring Hosts section (#2555)

bbcd4e2

ianballou pushed a commit to ianballou/foreman-documentation that referenced this pull request Dec 19, 2023

Re-modularize the Monitoring Hosts section (theforeman#2555)

4867b60

ianballou pushed a commit that referenced this pull request Dec 20, 2023

Re-modularize the Monitoring Hosts section (#2555)

39f1796

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-modularize the Monitoring Hosts section #2555

Re-modularize the Monitoring Hosts section #2555

mjivraja commented Oct 25, 2023 •

edited

github-actions bot commented Oct 25, 2023 •

edited

Lennonka left a comment •

edited

mjivraja commented Nov 2, 2023 •

edited

Lennonka left a comment

mjivraja commented Nov 3, 2023

mjivraja commented Nov 3, 2023

Lennonka commented Nov 3, 2023

mjivraja commented Nov 6, 2023

Lennonka left a comment

mjivraja commented Nov 20, 2023

mjivraja commented Nov 20, 2023

maximiliankolb left a comment

ShimShtein commented Dec 7, 2023

Lennonka commented Dec 7, 2023 •

edited

Lennonka commented Dec 7, 2023 •

edited

mjivraja commented Dec 8, 2023

Re-modularize the Monitoring Hosts section #2555

Re-modularize the Monitoring Hosts section #2555

Conversation

mjivraja commented Oct 25, 2023 • edited

github-actions bot commented Oct 25, 2023 • edited

Lennonka left a comment • edited

Choose a reason for hiding this comment

mjivraja commented Nov 2, 2023 • edited

Lennonka left a comment

Choose a reason for hiding this comment

mjivraja commented Nov 3, 2023

mjivraja commented Nov 3, 2023

Lennonka commented Nov 3, 2023

mjivraja commented Nov 6, 2023

Lennonka left a comment

Choose a reason for hiding this comment

mjivraja commented Nov 20, 2023

mjivraja commented Nov 20, 2023

maximiliankolb left a comment

Choose a reason for hiding this comment

ShimShtein commented Dec 7, 2023

Lennonka commented Dec 7, 2023 • edited

Lennonka commented Dec 7, 2023 • edited

mjivraja commented Dec 8, 2023

mjivraja commented Oct 25, 2023 •

edited

github-actions bot commented Oct 25, 2023 •

edited

Lennonka left a comment •

edited

mjivraja commented Nov 2, 2023 •

edited

Lennonka commented Dec 7, 2023 •

edited

Lennonka commented Dec 7, 2023 •

edited