Add 3.7.1 Release Notes #2583
Add 3.7.1 Release Notes #2583
Conversation
|
Let me know if I messed up the contributors section. It looked like it hadn't been updated since 3.7.0-rc1. I ran it from 3.6.0 to 3.7.1. Is that correct? |
|
The PR preview for 1ea8131 is available at theforeman-foreman-documentation-preview-pr-2583.surge.sh The following output files are affected by this PR: |
Griffin-Sullivan
force-pushed
the
3.7.1
branch
from
bc56e9c
to
db7bf6f
Compare
Griffin-Sullivan
force-pushed
the
3.7.1
branch
from
db7bf6f
to
198e5f2
Compare
| @@ -1,5 +1,4 @@ | |||
| We'd like to thank the following people who contributed to the Foreman {{page.version}} release: | |||
|
|
|||
| Adam Ruzicka, Alex Fisher, Amit Upadhye, Anthony Somerset, Bastian Schmidt, Bernhard Suttner, Chris Roberts, Christian Ruppert, Dirk Götz, Dirk Heinrichs, Dyrkon, Eric D. Helms, Evgeni Golov, Ewoud Kohl van Wijngaarden, Frank Adaemmer, Ian Ballou, Jeremy Lenz, Jonas Trüstedt, Kamil Szubrycht, Karolina Malyjurkova, Leos Stejskal, Lior Keren, Lucy Fu, Lukáš Zapletal, Manuel Laug, Marcel Kühlhorn, Marek Hulán, Maria Agaphontzev, Matt Darcy, Matěj Mudra, Nofar Alfassi, Oleh Fedorenko, Partha Aji, Pat Riehecky, Pavel Moravec, Peter Koprda, Quirin Pamp, Ron Lavi, Samir Jha, Sayan Das, Shim Shtein, William Clark, benjamin-robertson, kobybr, timdeluxe, Štefan Németh | |||
|
|
|||
| Adam Hosek, Adam Ruzicka, Alex Fisher, Alexey Masolov, Andrew Teixeira, Antonin Dvorak, Archana Kumari, Areyus, Bastian Schmidt, Bernhard Suttner, Damon Clinkscales, Daniel Alley, Dirk Götz, Eric Cook, Eric D. Helms, Erik Berg, Evgeni Golov, Ewoud Kohl van Wijngaarden, Girija Soni, Gordon Bleux, Griffin Sullivan, Ian Ballou, Jan Klare, Jerome Charaoui, Joshua Hoblitt, Leos Stejskal, Lior Keren, Lucy Fu, Marek Hulán, Maria Agaphontzev, Markus Bucher, Maximilian Kolb, Nagoor Shaik, Nofar Alfassi, Oleh Fedorenko, Pat Riehecky, Peter Bittner, Peter Koprda, Romain Tartière, Ron Lavi, Samir Jha, Sebastian Bublitz, Tim Meusel, Trey Dockendorf, Vijaykumar Sawant, William Clark, chr1s692, jc | |||
There was a problem hiding this comment.
Somehow I no longer see Anthony Somerset here.
Recently @wbclark pointed out that you can put everyone on their own line and in the rendered document it ends up as a single sentence. I think the best approach is to replace it first, commit that and then replace the whole set. The line by line comparison should make it very easy to see.
So use sed -i 's/, /,\n/g' guides/doc-Release_Notes/topics/foreman-contributors.adoc.
I've also opened theforeman/theforeman.org#2112 to automate the replacement of names.
There was a problem hiding this comment.
ok I placed them on their own lines. Was I supposed to add Anthony back?
There was a problem hiding this comment.
I don't have enough context to explicitly know of Anthony was, but I would assume that anyone present as a contributor in 3.7.0 should also be a contributor in 3.7.1
There was a problem hiding this comment.
What I meant was first create a commit that changes the list of contributors to multi line. Pretty much the output of sed -i 's/, /,\n/g' guides/doc-Release_Notes/topics/foreman-contributors.adoc except that also changes another unrelated line. Then update the list of contributors.
If you do that (and I did to show it) then you get ekohl@678804d where you can easily see which contributors are no longer listed.
That's quite a large list and I wonder what happened. Was it wrong in the first place, or is there an issue now?
Perhaps it's better to move forward with the release and only do the release notes now, leave the contributors to a separate step.
pr-processor
bot
added
the
Waiting on contributor
Griffin-Sullivan
force-pushed
the
3.7.1
branch
from
85e9872
to
1ea8131
Compare
pr-processor
bot
added
Needs re-review
and removed
Waiting on contributor
|
I just rebased this. Not sure what the next step should be @ekohl |
Please cherry-pick my commits into: