Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise the type of HTTP Proxy mentioned #2608

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Revise the type of HTTP Proxy mentioned #2608

merged 1 commit into from
Dec 20, 2023

Conversation

mjivraja
Copy link
Contributor

Presently, in setting up the Project in the IPv6 network, we mention only the IPv4 type of HTTP Proxy server which is incorrect. Because, the HTTP Proxy server configured with IPv4 only cannot communicate with the Project configured in the IPv6 network, except CDN. Hence, it should support both, IPv4 and IPv6.

Please cherry-pick my commits into:

  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • Foreman 3.2/Katello 4.4 on EL7 & EL8
  • Foreman 3.1/Katello 4.3 on EL7 & EL8 (Satellite 6.11 EL7/8; orcharhino 6.3 on EL7/8)
  • We do not accept PRs for Foreman older than 3.1.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2023 •
edited

The PR preview for a226974 is available at theforeman-foreman-documentation-preview-pr-2608.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

maximiliankolb
maximiliankolb reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion; change itself LGTM. Can someone else please ACK or do you have a link to another PR in foreman or bugzilla?

guides/common/modules/con_requirements-for-installation-in-an-ipv6-network.adoc Outdated Show resolved Hide resolved
@mjivraja
Copy link
Contributor Author

One small suggestion; change itself LGTM. Can someone else please ACK or do you have a link to another PR in foreman or bugzilla?

@ekohl Can you share your view on this?

ekohl
ekohl reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK on the technical side: this should have always been a dual stack HTTP proxy requirement.

guides/common/modules/con_requirements-for-installation-in-an-ipv6-network.adoc Outdated Show resolved Hide resolved
guides/common/modules/con_requirements-for-installation-in-an-ipv6-network.adoc Outdated Show resolved Hide resolved
@mjivraja
Revise the type of HTTP Proxy mentioned
a226974 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN. Hence, it should support both, IPv4 and IPv6.
@mjivraja mjivraja force-pushed the Fix-IPv4-HTTP-Proxy-mention-master branch from c33e100 to a226974 Compare December 20, 2023 06:41
maximiliankolb
maximiliankolb approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximiliankolb maximiliankolb merged commit 28d8c90 into theforeman:master Dec 20, 2023
8 checks passed
@maximiliankolb
Copy link
Contributor

Merged to master ✔️
I could not cherry-pick to 3.9 yet because someone has force pushed. See #2644

cc @mjivraja

@maximiliankolb maximiliankolb mentioned this pull request Dec 20, 2023
Merged
@mjivraja mjivraja deleted the Fix-IPv4-HTTP-Proxy-mention-master branch December 20, 2023 10:14
@mjivraja
Copy link
Contributor Author

Merged to master ✔️ I could not cherry-pick to 3.9 yet because someone has force pushed. See #2644

cc @mjivraja

Thank you @maximiliankolb for tagging this PR in 2644. Please let me know if we require separate PR for conflicts. I am assuming cherry-picking will begin for this PR once the 2644 is merged.

maximiliankolb pushed a commit that referenced this pull request Dec 20, 2023
@mjivraja @maximiliankolb
Reword IPv4 and IPv6 HTTP Proxy requirement (#2608)
584dfd1 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN.
Hence, it should support both, IPv4 and IPv6.

(cherry picked from commit 28d8c90)
maximiliankolb pushed a commit that referenced this pull request Dec 20, 2023
@mjivraja @maximiliankolb
Reword IPv4 and IPv6 HTTP Proxy requirement (#2608)
3afd09c 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN.
Hence, it should support both, IPv4 and IPv6.

(cherry picked from commit 28d8c90)
maximiliankolb pushed a commit that referenced this pull request Dec 20, 2023
@mjivraja @maximiliankolb
Reword IPv4 and IPv6 HTTP Proxy requirement (#2608)
0bc5c22 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN.
Hence, it should support both, IPv4 and IPv6.

(cherry picked from commit 28d8c90)
maximiliankolb pushed a commit that referenced this pull request Dec 20, 2023
@mjivraja @maximiliankolb
Reword IPv4 and IPv6 HTTP Proxy requirement (#2608)
244dbdc 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN.
Hence, it should support both, IPv4 and IPv6.

(cherry picked from commit 28d8c90)
maximiliankolb pushed a commit that referenced this pull request Dec 20, 2023
@mjivraja @maximiliankolb
Reword IPv4 and IPv6 HTTP Proxy requirement (#2608)
56da30c 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN.
Hence, it should support both, IPv4 and IPv6.

(cherry picked from commit 28d8c90)
maximiliankolb pushed a commit that referenced this pull request Dec 20, 2023
@mjivraja @maximiliankolb
Reword IPv4 and IPv6 HTTP Proxy requirement (#2608)
4cc5804 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN.
Hence, it should support both, IPv4 and IPv6.

(cherry picked from commit 28d8c90)
@maximiliankolb
Copy link
Contributor

Cherry-picks: ✔️
24f50d2..584dfd1 3.9 -> 3.9
0d87b85..3afd09c 3.8 -> 3.8
f70658b..0bc5c22 3.7 -> 3.7
0e1cfa4..244dbdc 3.6 -> 3.6
eeafa28..56da30c 3.5 -> 3.5
e3c9721..4cc5804 3.4 -> 3.4

There was a merge conflict on 3.3. If you want to backport to 3.3, please open a separate PR. Your call. @mjivraja

mjivraja added a commit to mjivraja/foreman-documentation that referenced this pull request Jan 2, 2024
@mjivraja
Reword IPv4 and IPv6 HTTP Proxy requirement (theforeman#2608)
7559243 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN.
Hence, it should support both, IPv4 and IPv6.

(cherry picked from commit 28d8c90)
mjivraja added a commit to mjivraja/foreman-documentation that referenced this pull request Jan 2, 2024
@mjivraja
Reword IPv4 and IPv6 HTTP Proxy requirement (theforeman#2608)
db98c93 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN.
Hence, it should support both, IPv4 and IPv6.

(cherry picked from commit 28d8c90)
mjivraja added a commit to mjivraja/foreman-documentation that referenced this pull request Jan 2, 2024
@mjivraja
Reword IPv4 and IPv6 HTTP Proxy requirement (theforeman#2608)
bfe2cf1 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN.
Hence, it should support both, IPv4 and IPv6.

(cherry picked from commit 28d8c90)
@mjivraja
Copy link
Contributor Author

mjivraja commented Jan 2, 2024

Cherry-picks: ✔️ 24f50d2..584dfd1 3.9 -> 3.9 0d87b85..3afd09c 3.8 -> 3.8 f70658b..0bc5c22 3.7 -> 3.7 0e1cfa4..244dbdc 3.6 -> 3.6 eeafa28..56da30c 3.5 -> 3.5 e3c9721..4cc5804 3.4 -> 3.4

There was a merge conflict on 3.3. If you want to backport to 3.3, please open a separate PR. Your call. @mjivraja

I find it is required even further. Here are the PRs resolving the conflict:

3.1: #2649
3.2: #2650
3.3: #2651

mjivraja added a commit to mjivraja/foreman-documentation that referenced this pull request Jan 2, 2024
@mjivraja
Reword IPv4 and IPv6 HTTP Proxy requirement (theforeman#2608)
a9fe35c 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN.
Hence, it should support both, IPv4 and IPv6.

(cherry picked from commit 28d8c90)
mjivraja added a commit to mjivraja/foreman-documentation that referenced this pull request Jan 2, 2024
@mjivraja
Reword IPv4 and IPv6 HTTP Proxy requirement (theforeman#2608)
a0d96ff 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN.
Hence, it should support both, IPv4 and IPv6.

(cherry picked from commit 28d8c90)
mjivraja added a commit to mjivraja/foreman-documentation that referenced this pull request Jan 2, 2024
@mjivraja
Reword IPv4 and IPv6 HTTP Proxy requirement (theforeman#2608)
037b621 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN.
Hence, it should support both, IPv4 and IPv6.

(cherry picked from commit 28d8c90)
maximiliankolb pushed a commit that referenced this pull request Jan 4, 2024
@mjivraja
Reword IPv4 and IPv6 HTTP Proxy requirement (#2608) (#2651)
95cefab 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN.
Hence, it should support both, IPv4 and IPv6.

(cherry picked from commit 28d8c90)
maximiliankolb pushed a commit that referenced this pull request Jan 4, 2024
@mjivraja
Reword IPv4 and IPv6 HTTP Proxy requirement (#2608) (#2650)
3217cda 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN.
Hence, it should support both, IPv4 and IPv6.

(cherry picked from commit 28d8c90)
maximiliankolb pushed a commit that referenced this pull request Jan 4, 2024
@mjivraja
Reword IPv4 and IPv6 HTTP Proxy requirement (#2608) (#2649)
f8aa02a 
Presently, in setting up the Project in the IPv6 network, we mention
only IPv4 type of HTTP Proxy server which is incorrect. Because,
HTTP Proxy server configured with IPv4 only cannot communicate with
Project configure in IPv6 network, except CDN.
Hence, it should support both, IPv4 and IPv6.

(cherry picked from commit 28d8c90)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@maximiliankolb maximiliankolb maximiliankolb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjivraja @maximiliankolb @ekohl