Report no longer lists SCA hosts #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR preview for 89dceae is available at theforeman-foreman-documentation-preview-pr-2612.surge.sh The following output files are affected by this PR: |
adamlazik1
reviewed
Nov 29, 2023
guides/common/modules/proc_generating-host-monitoring-reports.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_generating-host-monitoring-reports.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_generating-host-monitoring-reports.adoc
Outdated
Show resolved
Hide resolved
bangelic
force-pushed
the
bangelic-SAT-20478-Generating-Host-Monitoring-Reports-Adjust-Reporting-for-SCA
branch
2 times, most recently
from
4caac62
to
ca0a820
Compare
ianballou
requested changes
Dec 5, 2023
guides/common/modules/proc_generating-host-monitoring-reports.adoc
Outdated
Show resolved
Hide resolved
pr-processor
bot
added
Waiting on contributor
ianballou
approved these changes
Dec 5, 2023
|
@adamlazik1 @maximiliankolb Is this good to be merged? |
There was a problem hiding this comment.
Text LGTM apart from my suggestions to use an attribute.
I wonder about the best place to put this. Any comments/thoughts @asteflova ? Else we can merge this as is and could if desired move this later.
guides/common/modules/proc_generating-host-monitoring-reports.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_generating-host-monitoring-reports.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_generating-host-monitoring-reports.adoc
Outdated
Show resolved
Hide resolved
Good point on the placement. Where would the users need to know this? In the procedure itself, right? So how about moving this to step 1 of the web UI procedure?
Or maybe the procedure introduction? (I'm desperately trying to think of a solution that would not involve creating a new reference module with all the templates... :D) |
The subscription entitlement report no longer lists any hosts that are in SCA organizations. It will only output information for hosts that are in organizations that do not use simple content access.
Change "of" to "in" and bold a feature option.
Edited content into a list to clarify what each report contains.
Used attribute for hyphen/dash. Moved content into Procedure.
bangelic
force-pushed
the
bangelic-SAT-20478-Generating-Host-Monitoring-Reports-Adjust-Reporting-for-SCA
branch
from
403651c
to
89dceae
Compare
|
@asteflova @maximiliankolb I moved it into the procedure per Aneta's recommendation. |
|
@Lennonka Can you merge? |
Lennonka
pushed a commit
that referenced
this pull request
Dec 6, 2023
The subscription entitlement report no longer lists any hosts that are in SCA organizations. It will only output information for hosts that are in organizations that do not use simple content access. Address recommended suggestions Change "of" to "in" and bold a feature option. Edit content into list Edited content into a list to clarify what each report contains. Remove line about only using SCA Address recommendations Used attribute for hyphen/dash. Moved content into Procedure.
Lennonka
pushed a commit
that referenced
this pull request
Dec 6, 2023
The subscription entitlement report no longer lists any hosts that are in SCA organizations. It will only output information for hosts that are in organizations that do not use simple content access. Address recommended suggestions Change "of" to "in" and bold a feature option. Edit content into list Edited content into a list to clarify what each report contains. Remove line about only using SCA Address recommendations Used attribute for hyphen/dash. Moved content into Procedure.
10 tasks
ianballou
pushed a commit
to ianballou/foreman-documentation
that referenced
this pull request
Dec 19, 2023
The subscription entitlement report no longer lists any hosts that are in SCA organizations. It will only output information for hosts that are in organizations that do not use simple content access. Address recommended suggestions Change "of" to "in" and bold a feature option. Edit content into list Edited content into a list to clarify what each report contains. Remove line about only using SCA Address recommendations Used attribute for hyphen/dash. Moved content into Procedure.
ianballou
pushed a commit
that referenced
this pull request
Dec 20, 2023
The subscription entitlement report no longer lists any hosts that are in SCA organizations. It will only output information for hosts that are in organizations that do not use simple content access. Address recommended suggestions Change "of" to "in" and bold a feature option. Edit content into list Edited content into a list to clarify what each report contains. Remove line about only using SCA Address recommendations Used attribute for hyphen/dash. Moved content into Procedure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subscription entitlement report no longer lists any hosts that are
in SCA organizations. It will only output information for hosts that
are in organizations that do not use simple content access.
Please cherry-pick my commits into: