Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ccutil as a make rule #2876

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Mar 12, 2024

This removes a lot of logic from the GitHub Action and reuses infrastructure we already have in place. It also allows running in parallel.

It does give up the checks for images and images/common, but those are rather uncommon given how uncommon it is to introduce new guides.

Please cherry-pick my commits into:

  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (planned Satellite 6.15)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • We do not accept PRs for Foreman older than 3.3.

This removes a lot of logic from the GitHub Action and reuses
infrastructure we already have in place. It also allows running in
parallel.

It does give up the checks for images and images/common, but those are
rather uncommon given how uncommon it is to introduce new guides.
Copy link

The PR preview for 31678a0 is available at theforeman-foreman-documentation-preview-pr-2876.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me! I cannot commit much on ccutil though.

@ekohl
Copy link
Member Author

ekohl commented Mar 12, 2024

I'll admit I didn't look at ccutil myself either. @adamlazik1 could you take a look?

@adamlazik1
Copy link
Contributor

Personally, I'd probably not remove the image checks. Even though images are rarely changed, I can see this potentially causing us headache in the future.

@maximiliankolb
Copy link
Contributor

Why do we run ccutils in the first place? What would we lose if we drop this?

@ekohl
Copy link
Member Author

ekohl commented May 21, 2024

Why do we run ccutils in the first place? What would we lose if we drop this?

It's a tool that's used in Red Hat downstream to build, so it verifies that.

@ekohl ekohl merged commit d4fbf48 into theforeman:master May 21, 2024
8 checks passed
@ekohl ekohl deleted the ccutil-target branch May 21, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants