-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Reset custom SSL certificate to default self-signed #2886
Merged
maximiliankolb
merged 6 commits into
theforeman:master
from
mjivraja:Revert-from-custom-SSL-to-default-master
May 16, 2024
Merged
Add: Reset custom SSL certificate to default self-signed #2886
maximiliankolb
merged 6 commits into
theforeman:master
from
mjivraja:Revert-from-custom-SSL-to-default-master
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjivraja
added
the
Needs tech review
Requires a review from the technical perspective
label
Mar 14, 2024
mjivraja
force-pushed
the
Revert-from-custom-SSL-to-default-master
branch
4 times, most recently
from
March 15, 2024 06:48
623a99f
to
3fb466d
Compare
sayan3296
reviewed
Mar 16, 2024
...ules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-smartproxy.adoc
Outdated
Show resolved
Hide resolved
sayan3296
reviewed
Mar 17, 2024
...ules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-smartproxy.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, I did not test the procedure myself yet.
...modules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-project.adoc
Outdated
Show resolved
Hide resolved
...ules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-smartproxy.adoc
Outdated
Show resolved
Hide resolved
...ules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-smartproxy.adoc
Outdated
Show resolved
Hide resolved
...ules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-smartproxy.adoc
Outdated
Show resolved
Hide resolved
...ules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-smartproxy.adoc
Outdated
Show resolved
Hide resolved
...ules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-smartproxy.adoc
Outdated
Show resolved
Hide resolved
mjivraja
force-pushed
the
Revert-from-custom-SSL-to-default-master
branch
2 times, most recently
from
March 21, 2024 10:43
bab196a
to
85f53e9
Compare
ehelms
reviewed
Mar 21, 2024
...ules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-smartproxy.adoc
Outdated
Show resolved
Hide resolved
mjivraja
force-pushed
the
Revert-from-custom-SSL-to-default-master
branch
from
April 24, 2024 12:52
85f53e9
to
c11fdce
Compare
maximiliankolb
requested changes
Apr 25, 2024
guides/common/modules/con_using-custom-ssl-certificate-for-hosts.adoc
Outdated
Show resolved
Hide resolved
...on/modules/ref_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-hosts.adoc
Outdated
Show resolved
Hide resolved
...ules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-smartproxy.adoc
Outdated
Show resolved
Hide resolved
...ules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-smartproxy.adoc
Outdated
Show resolved
Hide resolved
...ules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-smartproxy.adoc
Outdated
Show resolved
Hide resolved
...ules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-smartproxy.adoc
Outdated
Show resolved
Hide resolved
...modules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-project.adoc
Outdated
Show resolved
Hide resolved
...modules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-project.adoc
Outdated
Show resolved
Hide resolved
...modules/proc_reset-custom-ssl-certificate-to-default-self-signed-certificate-on-project.adoc
Outdated
Show resolved
Hide resolved
pr-processor
bot
added
Waiting on contributor
Requires an action from the author
Needs re-review
and removed
Waiting on contributor
Requires an action from the author
labels
Apr 25, 2024
Documented the procedure for end-users to revert from Custom SSL to default self-signed certificate for Project, SmartProxy, and Hosts guide. This was required in the case where Custom SSL certificate were expired for Project and CA was not available to provide new signed certificates that caused business outages or production delays. Also, fixed minor things in Deploying custom SSL certificate to hosts https://bugzilla.redhat.com/show_bug.cgi?id=1874045 Rerun GitHub Actions
Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
mjivraja
force-pushed
the
Revert-from-custom-SSL-to-default-master
branch
from
April 30, 2024 06:31
a4d8536
to
1a9a2ed
Compare
maximiliankolb
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM.
maximiliankolb
pushed a commit
that referenced
this pull request
May 16, 2024
(cherry picked from commit bb8131c)
mjivraja
added a commit
to mjivraja/foreman-documentation
that referenced
this pull request
May 16, 2024
) (cherry picked from commit bb8131c)
mjivraja
added a commit
to mjivraja/foreman-documentation
that referenced
this pull request
May 16, 2024
) (cherry picked from commit bb8131c)
mjivraja
added a commit
to mjivraja/foreman-documentation
that referenced
this pull request
May 16, 2024
) (cherry picked from commit bb8131c)
ekohl
pushed a commit
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented the procedure for end-users to revert from Custom SSL to default self-signed certificate for Project, SmartProxy, and Hosts guide. This was required in the case where Custom SSL certificates were expired for Project and CA was not available to provide new signed certificates that caused business outages or production delays. Also, I fixed minor things in Deploying custom SSL certificates to hosts
https://bugzilla.redhat.com/show_bug.cgi?id=1874045
Please cherry-pick my commits into: