Remove deprecated plugin foreman_hooks #2959
Conversation
|
The PR preview for 5d3587f is available at theforeman-foreman-documentation-preview-pr-2959.surge.sh The following output files are affected by this PR: |
|
Hey @adamlazik1 Do you know more about the deprecation of the foreman_hooks plugin with Foreman 3.11? Is this official yet? Do you have any BZ? If we decide to drop the docs, we should get at least one ACK from a Foreman developer. Do you know who to ping? |
|
All of the webhook and shellhook functionality should remain unchanged as foreman_hooks is being replaced with foreman_webhooks. We actually discussed this today with @adamruzicka so I believe it is safe to keep the documentation. |
|
Maybe we could drop the migration procedure, I will confirm that. |
|
Okay so we should also keep the migration chapter for people who have been using foreman_hooks, upgrade from 3.10, and wonder why it suddenly stopped working. We can remove the migration chapter in 3.12. Only things that should be removed in this PR is the mention from glossary and the sentence about backing up foreman hooks. |
|
The removal also deserves a release note. @adamruzicka |
|
@ekohl if you are talking about a downstream release note, we have that completed. |
|
@adamlazik1 I was thinking about upstream. |
|
@ekohl in that case, should I create a PR to add this RN into upstream manually? |
maximiliankolb
force-pushed
the
remove_foreman_hooks
branch
from
f72e5e8
to
5d3587f
Compare
will not be part of Foreman 3.11.
foreman_hooks is deprecated and will be removed with Foreman 3.11. See https://github.com/theforeman/foreman_hooks
This PR is a response to #2950 (comment)